net: Rename FileStream::Open/Close with OpenSync/CloseSync.

net: Rename FileStream::Open/Close with OpenSync/CloseSync.

This is in preparation for implementing async versions of Open()
and Close().

The existing clients are changed to use OpenSync/CloseSync.
No logic is changed.

TEST=try bots to confirm everythign is built as before.
BUG=72001
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121064

[satorux1, 2012-02-07 18:06:27]

marked async usage.

http://codereview.chromium.org/9349005/diff/3002/content/browser/renderer_hos...
File content/browser/renderer_host/redirect_to_file_resource_handler.cc (right):

http://codereview.chromium.org/9349005/diff/3002/content/browser/renderer_hos...
content/browser/renderer_host/redirect_to_file_resource_handler.cc:169:
base::PLATFORM_FILE_ASYNC,
async

http://codereview.chromium.org/9349005/diff/3002/net/url_request/url_request_...
File net/url_request/url_request_file_job.cc (right):

http://codereview.chromium.org/9349005/diff/3002/net/url_request/url_request_...
net/url_request/url_request_file_job.cc:315: base::PLATFORM_FILE_ASYNC;
async.

http://codereview.chromium.org/9349005/diff/3002/webkit/blob/blob_url_request...
File webkit/blob/blob_url_request_job.cc (right):

http://codereview.chromium.org/9349005/diff/3002/webkit/blob/blob_url_request...
webkit/blob/blob_url_request_job.cc:48: base::PLATFORM_FILE_ASYNC;
async

http://codereview.chromium.org/9349005/diff/3002/webkit/blob/blob_url_request...
webkit/blob/blob_url_request_job.cc:332: stream_.reset(new
net::FileStream(file.ReleaseValue(), kFileOpenFlags, NULL));
async.

http://codereview.chromium.org/9349005/diff/3002/webkit/fileapi/file_system_u...
File webkit/fileapi/file_system_url_request_job.cc (right):

http://codereview.chromium.org/9349005/diff/3002/webkit/fileapi/file_system_u...
webkit/fileapi/file_system_url_request_job.cc:38: base::PLATFORM_FILE_ASYNC;
async.

http://codereview.chromium.org/9349005/diff/3002/webkit/fileapi/file_system_u...
webkit/fileapi/file_system_url_request_job.cc:270: stream_.reset(new
net::FileStream(file.ReleaseValue(), kFileFlags, NULL));
async.

[satorux1, 2012-02-07 18:23:37]

Hi Will,

I originally thought about adding CompletionCallback to the existing
Open/Close() functions to make them behave asynchronously when
PLATFORM_FILE_ASYNC is specified. However, I changed my mind and instead renamed
the existing functions to OpenSync/CloseSync(). Here's rationale:

1. Passing an empty CompletionCallback for sync behaviors looks rather unclean.
2. There are four places where FileStream is used in the async mode. Changing
all these places to migrate to async Open/Close at once is difficult. We should
do migration like this one by one.

That said, I think it'd be also nice to split the existing Read/Write functions
to Read/Write (takes a CompletionCallback) and ReadSync/WriteSync (does not take
a CompletionCallback).

What do you think?

[willchan no longer on Chromium, 2012-02-07 23:47:10]

lgtm

[satorux1, 2012-02-08 08:16:26]

jam@, please take a look at content/* changes
tony@, please take a look at webkit/* changes

Thanks!

[tony, 2012-02-08 17:39:37]

webkit rubber stamp LGTM

[jam, 2012-02-08 18:04:28]

content lgtm

[commit-bot: I haz the power, 2012-02-08 18:57:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/9349005/11003

[commit-bot: I haz the power, 2012-02-08 21:57:10]

Change committed as 121064