Issue 9349004: Early-return in RenderViewImpl::DidFlushPaint() if there is no WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9349004: Early-return in RenderViewImpl::DidFlushPaint() if there is no WebView. (Closed)

Created:
8 years, 10 months ago by Wez

Modified:
8 years, 10 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Early-return in RenderViewImpl::DidFlushPaint() if there is no WebView. CL 9328016 exposed a bug with seemingly-unused stats code assuming that the RenderView's WebView must be valid when DidFlushPaint() is called, which may not be true if RenderWidget::OnSwapBuffersComplete is notified while the widget is closing down. We'll follow up by verifying the stats code is unnecessary and removing it (see bug 112942). BUG=112921, 111639, 112942 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120715

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/renderer/render_view_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9349004/1

8 years, 10 months ago (2012-02-07 00:22:45 UTC) #3

Change committed as 120715

Expand Messages | Collapse Messages