Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 9349003: [uber page] Improve a few titles for overall consistency. (Closed)

Created:
8 years, 10 months ago by csilv
Modified:
8 years, 10 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Improve titles for homePage and StartupPages overlays for consistency. BUG=112232 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120735

Patch Set 1 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M chrome/browser/resources/options2/home_page_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/home_page_overlay.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/startup_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/startup_overlay.js View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 2 chunks +2 lines, -1 line 2 comments Download
M chrome/browser/ui/webui/options2/startup_pages_handler2.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
csilv
+jhawkins for review
8 years, 10 months ago (2012-02-07 01:51:11 UTC) #1
James Hawkins
https://chromiumcodereview.appspot.com/9349003/diff/1009/chrome/browser/ui/webui/options2/browser_options_handler2.cc File chrome/browser/ui/webui/options2/browser_options_handler2.cc (right): https://chromiumcodereview.appspot.com/9349003/diff/1009/chrome/browser/ui/webui/options2/browser_options_handler2.cc#newcode184 chrome/browser/ui/webui/options2/browser_options_handler2.cc:184: RegisterTitle(localized_strings, "homePageOverlay", Wha? Why are we registering the title ...
8 years, 10 months ago (2012-02-07 01:54:22 UTC) #2
csilv
https://chromiumcodereview.appspot.com/9349003/diff/1009/chrome/browser/ui/webui/options2/browser_options_handler2.cc File chrome/browser/ui/webui/options2/browser_options_handler2.cc (right): https://chromiumcodereview.appspot.com/9349003/diff/1009/chrome/browser/ui/webui/options2/browser_options_handler2.cc#newcode184 chrome/browser/ui/webui/options2/browser_options_handler2.cc:184: RegisterTitle(localized_strings, "homePageOverlay", On 2012/02/07 01:54:22, James Hawkins wrote: > ...
8 years, 10 months ago (2012-02-07 01:58:34 UTC) #3
James Hawkins
Indeed, please do.
8 years, 10 months ago (2012-02-07 01:58:56 UTC) #4
csilv
I'd prefer to commit this CL. Breaking out the home page code into a new ...
8 years, 10 months ago (2012-02-07 02:27:55 UTC) #5
James Hawkins
lgtm
8 years, 10 months ago (2012-02-07 04:51:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csilv@chromium.org/9349003/1009
8 years, 10 months ago (2012-02-07 04:52:19 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 07:02:00 UTC) #8
Change committed as 120735

Powered by Google App Engine
This is Rietveld 408576698