Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9348113: Fix two crash and potential leak&crash (Closed)

Created:
8 years, 10 months ago by oshima
Modified:
8 years, 10 months ago
Reviewers:
pkotwicz, sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix two crash and potential leak&crash * closing window while menu is open This only fix part of this. There is another place that crashes and i'll address it in separate CL. * closing window while modal dialog is open * release resources early and use window::Close in BallonViewImpl This was causing crash if the widget gets closed earlier than DelayedClose task is executed. BUG=114123 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122028

Patch Set 1 #

Total comments: 4

Patch Set 2 : revert unnecessary file, updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M ash/accelerators/accelerator_dispatcher.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +11 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_dispatcher_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
oshima
8 years, 10 months ago (2012-02-14 23:51:43 UTC) #1
oshima
8 years, 10 months ago (2012-02-14 23:58:48 UTC) #2
sky
http://codereview.chromium.org/9348113/diff/1/ash/accelerators/accelerator_dispatcher.h File ash/accelerators/accelerator_dispatcher.h (right): http://codereview.chromium.org/9348113/diff/1/ash/accelerators/accelerator_dispatcher.h#newcode34 ash/accelerators/accelerator_dispatcher.h:34: // aura::WindowObserver implements implements -> overrides http://codereview.chromium.org/9348113/diff/1/ui/aura/root_window_host_linux.cc File ui/aura/root_window_host_linux.cc ...
8 years, 10 months ago (2012-02-15 00:02:04 UTC) #3
oshima
http://codereview.chromium.org/9348113/diff/1/ash/accelerators/accelerator_dispatcher.h File ash/accelerators/accelerator_dispatcher.h (right): http://codereview.chromium.org/9348113/diff/1/ash/accelerators/accelerator_dispatcher.h#newcode34 ash/accelerators/accelerator_dispatcher.h:34: // aura::WindowObserver implements On 2012/02/15 00:02:04, sky wrote: > ...
8 years, 10 months ago (2012-02-15 00:18:00 UTC) #4
sky
LGTM
8 years, 10 months ago (2012-02-15 01:12:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9348113/10
8 years, 10 months ago (2012-02-15 01:13:08 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 04:07:59 UTC) #7 
Change committed as 122028

Powered by Google App Engine
This is Rietveld 408576698