Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9348087: Do not call ContentMainDelegate::ProcessExiting if BasicStartupComplete return true. (Closed)

Created:
8 years, 10 months ago by Marshall
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Do not call ContentMainDelegate::ProcessExiting if BasicStartupComplete return true. This fixes a regression on Linux caused by http://crrev.com/121454. BUG=114121 TEST=Run chrome --version Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121906

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/app/content_main_runner.cc View 1 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marshall
Please review.
8 years, 10 months ago (2012-02-14 16:58:24 UTC) #1
jam
lgtm
8 years, 10 months ago (2012-02-14 17:00:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marshall@chromium.org/9348087/1001
8 years, 10 months ago (2012-02-14 17:03:09 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-14 18:38:11 UTC) #4
Change committed as 121906

Powered by Google App Engine
This is Rietveld 408576698