Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 9348069: Move the charset inteface to "trusted" (we can't implement this efficiently (Closed)

Created:
8 years, 10 months ago by brettw
Modified:
8 years, 10 months ago
Reviewers:
bbudge
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Move the charset inteface to "trusted" (we can't implement this efficiently in NaCl) and modify to no longer require the memory interface. This keeps the old interface and implements it in terms of the newer one. We can remove it when all callers have been updated. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121159

Patch Set 1 #

Total comments: 4

Patch Set 2 : STUPID REQUIRED REVIEW COMMENT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -213 lines) Patch
A ppapi/api/trusted/ppb_char_set_trusted.idl View 1 1 chunk +95 lines, -0 lines 0 comments Download
A ppapi/c/trusted/ppb_char_set_trusted.h View 1 1 chunk +124 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
D ppapi/shared_impl/ppb_char_set_shared.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ppapi/shared_impl/ppb_char_set_shared.cc View 1 chunk +0 lines, -154 lines 0 comments Download
A ppapi/shared_impl/private/ppb_char_set_shared.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ppapi/shared_impl/private/ppb_char_set_shared.cc View 1 chunk +239 lines, -0 lines 0 comments Download
M ppapi/tests/test_char_set.h View 3 chunks +4 lines, -0 lines 0 comments Download
M ppapi/tests/test_char_set.cc View 1 4 chunks +187 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_char_set_thunk.cc View 5 chunks +52 lines, -21 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
8 years, 10 months ago (2012-02-08 21:35:13 UTC) #1
bbudge
LGTM w/nits http://codereview.chromium.org/9348069/diff/1/ppapi/api/trusted/ppb_char_set_trusted.idl File ppapi/api/trusted/ppb_char_set_trusted.idl (right): http://codereview.chromium.org/9348069/diff/1/ppapi/api/trusted/ppb_char_set_trusted.idl#newcode7 ppapi/api/trusted/ppb_char_set_trusted.idl:7: * This file defines the <code>PPB_TCPSocket_Private</code> interface. ...
8 years, 10 months ago (2012-02-08 21:56:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9348069/7001
8 years, 10 months ago (2012-02-09 00:38:24 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-09 02:11:22 UTC) #4
Change committed as 121159

Powered by Google App Engine
This is Rietveld 408576698