--print_bots arg to 'gcl try' for debugging PRESUBMIT.py changes.

--print_bots arg to 'gcl try' for debugging PRESUBMIT.py changes.

Prints the bots a tryjob would use if sent out.
(Does not send out the job.)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121409

[John Grabowski, 2012-02-08 20:57:43]

Note my presubmit script failed.  I think it is unrelated.


Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 879, in testUpdateCheckout
    self.assertTrue(out in (msg1, msg2), (out, msg1, msg2))
AssertionError: ("\n_____ foo at refs/heads/master\n\n________ running 'git
clone --progress -b master --verbose /tmp/tmpLGTBTU/./.git /tmp/tmpD7nTeO/foo'
in '/tmp/tmpD7nTeO'\nCloning into '/tmp/tmpD7nTeO/foo'...\ndone.\n", "\n_____
foo at refs/heads/master\n\n________ running 'git clone --progress -b master
--verbose /tmp/tmpLGTBTU/./.git /tmp/tmpD7nTeO/foo' in
'/tmp/tmpD7nTeO'\nInitialized empty Git repository in
/tmp/tmpD7nTeO/foo/.git/\n", "\n_____ foo at refs/heads/master\n\n________
running 'git clone --progress -b master --verbose /tmp/tmpLGTBTU/./.git
/tmp/tmpD7nTeO/foo' in '/tmp/tmpD7nTeO'\nCloning into
/tmp/tmpD7nTeO/foo...\ndone.\n")

[M-A Ruel, 2012-02-08 21:22:55]

lgtm with one change. Use the CQ to commit this.

http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py
File trychange.py (right):

http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py#newcode544
trychange.py:544: " and exit.  Do not send patch.")
It's a bit confusing with the fact that --dry_run doesn't send the patch too but
has a different effect. Oh well.

http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py#newcode769
trychange.py:769: import presubmit_support
This code needs to be extracted in a function so
tools/build/commit-queue/verification/try_server.py can use it. That's just FYI
and outside the scope of this CL.

Well, since this executes a PRESUBMIT.py, it probably makes sense to run it out
of process _anyway_ so just parsing the stdout is probably good enough.

http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py#newcode795
trychange.py:795: print 'Bots which would be used: ' + str(options.bot)
I'd prefer:
print 'Bots which would be used:'
for bot in options.bot:
  print '  %s' % bot

it'd be easier on the eyes.

[John Grabowski, 2012-02-08 21:31:38]

Hmm... looks like --dry_run prints this same information, so I'm abandoning this
as unnecessary.

> lgtm with one change. Use the CQ to commit this.
> 
> http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py
> File trychange.py (right):
> 
> http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py#newcode544
> trychange.py:544: " and exit.  Do not send patch.")
> It's a bit confusing with the fact that --dry_run doesn't send the patch too
but
> has a different effect. Oh well.
> 
> http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py#newcode769
> trychange.py:769: import presubmit_support
> This code needs to be extracted in a function so
> tools/build/commit-queue/verification/try_server.py can use it. That's just
FYI
> and outside the scope of this CL.
> 
> Well, since this executes a PRESUBMIT.py, it probably makes sense to run it
out
> of process _anyway_ so just parsing the stdout is probably good enough.
> 
> http://chromiumcodereview.appspot.com/9348068/diff/1/trychange.py#newcode795
> trychange.py:795: print 'Bots which would be used: ' + str(options.bot)
> I'd prefer:
> print 'Bots which would be used:'
> for bot in options.bot:
>   print '  %s' % bot
> 
> it'd be easier on the eyes.

[M-A Ruel, 2012-02-08 21:45:04]

On 2012/02/08 21:31:38, John Grabowski wrote:
> Hmm... looks like --dry_run prints this same information, so I'm abandoning
this
> as unnecessary.

--dry_run is very verbose. Yours is easy to parse. So I think it's a useful CL.

[John Grabowski, 2012-02-08 22:33:13]

OK then; updated and feedback applied.

[M-A Ruel, 2012-02-09 00:37:27]

lgtm after the fix

http://chromiumcodereview.appspot.com/9348068/diff/4/trychange.py
File trychange.py (right):

http://chromiumcodereview.appspot.com/9348068/diff/4/trychange.py#newcode799
trychange.py:799: return 0
Fix alignment, otherwise it only prints the first bot.

[John Grabowski, 2012-02-09 01:42:53]

http://chromiumcodereview.appspot.com/9348068/diff/4/trychange.py
File trychange.py (right):

http://chromiumcodereview.appspot.com/9348068/diff/4/trychange.py#newcode799
trychange.py:799: return 0
On 2012/02/09 00:37:27, Marc-Antoine Ruel wrote:
> Fix alignment, otherwise it only prints the first bot.

ha good catch thx

[commit-bot: I haz the power, 2012-02-10 05:38:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/9348068/5001

[commit-bot: I haz the power, 2012-02-10 05:45:05]

Change committed as 121409