chrome/browser/sync/sync_ui_util.cc - Issue 9348036: Trim code from sync's ServerConnectionManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_ui_util.cc

Issue 9348036: Trim code from sync's ServerConnectionManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Delete some more code Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/engine/all_status.cc ('K') | « chrome/browser/sync/sessions/test_util.cc ('k') | chrome/browser/sync/test/engine/mock_connection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sync_ui_util.cc

diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc

index 2775d4d739dbf322bc6e586565350b38fff1e9c4..a9cdfdf74bcfc22a055baee7b45f09611e5a9c38 100644

--- a/chrome/browser/sync/sync_ui_util.cc

+++ b/chrome/browser/sync/sync_ui_util.cc

@@ -292,11 +292,6 @@ MessageType GetStatusInfo(ProfileSyncService* service,

NULL, NULL, NULL);

}

result_type = SYNC_ERROR;

- } else if (!status.authenticated) {

- if (status_label) {

- status_label->assign(

- l10n_util::GetStringUTF16(IDS_SYNC_ACCOUNT_DETAILS_NOT_ENTERED));

- }

}

} else if (service->unrecoverable_error_detected()) {

result_type = SYNC_ERROR;

@@ -514,8 +509,6 @@ void ConstructAboutInformation(ProfileSyncService* service,

full_status.summary));

strings->SetString("version", GetVersionString());

- strings->Set("authenticated",

- new base::FundamentalValue(full_status.authenticated));

strings->SetString("auth_problem",

sync_ui_util::MakeSyncAuthErrorText(

service->GetAuthError().state()));

@@ -533,12 +526,6 @@ void ConstructAboutInformation(ProfileSyncService* service,

"Client ID",

full_status.unique_id.empty() ? "none" : full_status.unique_id);

sync_ui_util::AddBoolSyncDetail(details,

- "Server Up",

- full_status.server_up);

- sync_ui_util::AddBoolSyncDetail(details,

- "Server Reachable",

- full_status.server_reachable);

- sync_ui_util::AddBoolSyncDetail(details,

"Notifications Enabled",

full_status.notifications_enabled);

sync_ui_util::AddIntSyncDetail(details,