chrome/browser/sync/internal_api/sync_manager.cc - Issue 9348036: Trim code from sync's ServerConnectionManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/internal_api/sync_manager.cc

Issue 9348036: Trim code from sync's ServerConnectionManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Back off some changes Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/internal_api/sync_manager.cc

diff --git a/chrome/browser/sync/internal_api/sync_manager.cc b/chrome/browser/sync/internal_api/sync_manager.cc

index 7421fdce43c93d091b6b4424e9ad82157ea601b1..e6c1f2789bd4a443729ae5424465ac605a9d45c5 100644

--- a/chrome/browser/sync/internal_api/sync_manager.cc

+++ b/chrome/browser/sync/internal_api/sync_manager.cc

@@ -677,9 +677,6 @@ SyncManager::SyncManager(const std::string& name)

SyncManager::Status::Status()

: summary(INVALID),

- authenticated(false),

lipalani1 2012/02/11 00:12:10 Not sure removing authenticated is a good idea. I

- server_up(false),

- server_reachable(false),

notifications_enabled(false),

notifications_received(0),

unsynced_count(0),

@@ -1721,7 +1718,6 @@ void SyncManager::SyncInternal::OnIPAddressChangedImpl() {

void SyncManager::SyncInternal::OnServerConnectionEvent(

const ServerConnectionEvent& event) {

DCHECK(thread_checker_.CalledOnValidThread());

- allstatus_.HandleServerConnectionEvent(event);

if (event.connection_code ==

browser_sync::HttpResponse::SERVER_CONNECTION_OK) {

FOR_EACH_OBSERVER(SyncManager::Observer, observers_,