chrome/browser/sync/sync_ui_util.cc - Issue 9348036: Trim code from sync's ServerConnectionManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_ui_util.cc

Issue 9348036: Trim code from sync's ServerConnectionManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: small updates Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/internal_api/sync_manager.cc ('K') | « chrome/browser/sync/profile_sync_service_harness.cc ('k') | chrome/browser/sync/test/engine/mock_connection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sync_ui_util.cc

diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc

index 3dd75713aeaa1c4d9faddfdefe175e029098ece7..984ec17faa5df170fadc47b6b92e1a773d39276d 100644

--- a/chrome/browser/sync/sync_ui_util.cc

+++ b/chrome/browser/sync/sync_ui_util.cc

@@ -291,11 +291,6 @@ MessageType GetStatusInfo(ProfileSyncService* service,

NULL, NULL, NULL);

}

result_type = SYNC_ERROR;

- } else if (!status.authenticated) {

rlarocque 2012/02/08 01:57:29 Fred and I are reasonably convinced this is dead c

- if (status_label) {

- status_label->assign(

- l10n_util::GetStringUTF16(IDS_SYNC_ACCOUNT_DETAILS_NOT_ENTERED));

- }

}

} else if (service->unrecoverable_error_detected()) {

result_type = SYNC_ERROR;

@@ -512,8 +507,6 @@ void ConstructAboutInformation(ProfileSyncService* service,

full_status.summary));

strings->SetString("version", GetVersionString());

- strings->Set("authenticated",

- new base::FundamentalValue(full_status.authenticated));

strings->SetString("auth_problem",

sync_ui_util::MakeSyncAuthErrorText(

service->GetAuthError().state()));

@@ -531,12 +524,6 @@ void ConstructAboutInformation(ProfileSyncService* service,

"Client ID",

full_status.unique_id.empty() ? "none" : full_status.unique_id);

sync_ui_util::AddBoolSyncDetail(details,

- "Server Up",

- full_status.server_up);

- sync_ui_util::AddBoolSyncDetail(details,

- "Server Reachable",

- full_status.server_reachable);

- sync_ui_util::AddBoolSyncDetail(details,

"Notifications Enabled",

full_status.notifications_enabled);

sync_ui_util::AddIntSyncDetail(details,