Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: chrome/browser/sync/engine/sync_scheduler.h

Issue 9348036: Trim code from sync's ServerConnectionManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: small updates Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/sync_scheduler.h
diff --git a/chrome/browser/sync/engine/sync_scheduler.h b/chrome/browser/sync/engine/sync_scheduler.h
index 9c84ba53a846e6519e6c427cc96ccfc822933cc4..6acbf81d3a913e153ae417252f5e7c50c0c881c9 100644
--- a/chrome/browser/sync/engine/sync_scheduler.h
+++ b/chrome/browser/sync/engine/sync_scheduler.h
@@ -108,12 +108,6 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
// TODO(tim): Look at URLRequestThrottlerEntryInterface.
static base::TimeDelta GetRecommendedDelay(const base::TimeDelta& base_delay);
- // Called when credentials are updated by the user.
- void OnCredentialsUpdated();
-
- // Called when the network layer detects a connection status change.
- void OnConnectionStatusChange();
-
// SyncSession::Delegate implementation.
virtual void OnSilencedUntil(
const base::TimeTicks& silenced_until) OVERRIDE;
@@ -128,6 +122,9 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
virtual void OnSyncProtocolError(
const sessions::SyncSessionSnapshot& snapshot) OVERRIDE;
+ // Called when the root cause of the current connection error is fixed.
+ void OnServerConnectionErrorFixed();
+
private:
enum JobProcessDecision {
// Indicates we should continue with the current job.
@@ -327,9 +324,6 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
// re-established, mode changes etc.
void DoPendingJobIfPossible(bool is_canary_job);
- // Called when the root cause of the current connection error is fixed.
- void OnServerConnectionErrorFixed();
-
// The pointer is owned by the caller.
browser_sync::sessions::SyncSession* CreateSyncSession(
const browser_sync::sessions::SyncSourceInfo& info);
@@ -343,10 +337,6 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
SyncerStep* start,
SyncerStep* end);
- // Used to update |server_connection_ok_|, see below.
- void UpdateServerConnectionManagerStatus(
- HttpResponse::ServerConnectionCode code);
-
// Called once the first time thread_ is started to broadcast an initial
// session snapshot containing data like initial_sync_ended. Important when
// the client starts up and does not need to perform an initial sync.
@@ -391,12 +381,6 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
// since the nudges could be for different types. Current impl doesn't care.
base::TimeTicks last_sync_session_end_time_;
- // Have we observed a valid server connection?
- bool server_connection_ok_;
-
- // The latest connection code we got while trying to connect.
- HttpResponse::ServerConnectionCode connection_code_;
-
// Tracks in-flight nudges so we can coalesce.
scoped_ptr<SyncSessionJob> pending_nudge_;

Powered by Google App Engine
This is Rietveld 408576698