Trim code from sync's ServerConnectionManager

chrome/browser/sync/engine/all_status.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/all_status.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/port.h"
@@ skipping 78 matching lines @@
       ++status.useless_sync_cycles;
     } else {
       ++status.useful_sync_cycles;
     }
   }
   return status;
 }
 
 void AllStatus::CalcStatusChanges() {
   const bool unsynced_changes = status_.unsynced_count > 0;
-  const bool online = status_.authenticated &&
-    status_.server_reachable && status_.server_up;
+  // TODO(rlarocque): AllStatus currently has no way to inquire about the
+  // SyncScheduler's backoff state.  We should fix that, then use it to update
+  // the 'offline' state here.  However, it's important to keep in mind that
+  // there really is no such thing as offline according to our SyncScheduler.
+  // The exponential backoff never gives up.
+  const bool online = true;

[lipalani1, 2012/02/22 18:28:50]

This does not look right?

Basically only the first if block would ever be executed(and you might get a
compiler warning as well) and the status can never be offline etc.

I think we should try to preserver this. I have some ideas in the message
section of this feedback.

   if (online) {
     if (status_.syncing)
       status_.summary = sync_api::SyncManager::Status::SYNCING;
     else
       status_.summary = sync_api::SyncManager::Status::READY;
   } else if (!status_.initial_sync_ended) {
     status_.summary = sync_api::SyncManager::Status::OFFLINE_UNUSABLE;
   } else if (unsynced_changes) {
     status_.summary = sync_api::SyncManager::Status::OFFLINE_UNSYNCED;
   } else {
@@ skipping 17 matching lines @@
     case SyncEngineEvent::ACTIONABLE_ERROR:
       status_ = CreateBlankStatus();
       status_.sync_protocol_error = event.snapshot->errors.sync_protocol_error;
       break;
     default:
       LOG(ERROR) << "Unrecognized Syncer Event: " << event.what_happened;
       break;
   }
 }
 
-void AllStatus::HandleServerConnectionEvent(
-    const ServerConnectionEvent& event) {
-  ScopedStatusLock lock(this);
-  status_.server_up = IsGoodReplyFromServer(event.connection_code);
-  status_.server_reachable = event.server_reachable;
-
-  if (event.connection_code == HttpResponse::SERVER_CONNECTION_OK) {
-    status_.authenticated = true;
-  } else {
-    status_.authenticated = false;
-  }
-}
-
 sync_api::SyncManager::Status AllStatus::status() const {
   base::AutoLock lock(mutex_);
   return status_;
 }
 
 void AllStatus::SetNotificationsEnabled(bool notifications_enabled) {
   ScopedStatusLock lock(this);
   status_.notifications_enabled = notifications_enabled;
 }
 
@@ skipping 26 matching lines @@
     : allstatus_(allstatus) {
   allstatus->mutex_.Acquire();
 }
 
 ScopedStatusLock::~ScopedStatusLock() {
   allstatus_->CalcStatusChanges();
   allstatus_->mutex_.Release();
 }
 
 }  // namespace browser_sync