Adds gpu_info_collector and ImageTransportSurface methods for android.

Adds gpu_info_collector and ImageTransportSurface methods for android.
These are required to build content_unittests.

BUG=None
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121023

[apatrick_chromium, 2012-02-07 23:22:26]

lgtm

https://chromiumcodereview.appspot.com/9348033/diff/2001/content/common/gpu/i...
File content/common/gpu/image_transport_surface_android.cc (right):

https://chromiumcodereview.appspot.com/9348033/diff/2001/content/common/gpu/i...
content/common/gpu/image_transport_surface_android.cc:5: #if defined(ENABLE_GPU)
This isn't needed now. No need to copy and paste the ifdef :)

https://chromiumcodereview.appspot.com/9348033/diff/2001/content/common/gpu/i...
content/common/gpu/image_transport_surface_android.cc:9: #include
"ui/gfx/gl/gl_surface.h"
needed?

[jam, 2012-02-07 23:23:16]

I understand why there might be an android version of image_transport_surface,
since android is a platform and we have versions for mac/win/linux.

But gpu_info_collector_android.cc appears to be just android stubs for a cc file
that's shared among all existing platforms. Adding stub files for android is a
maintenance cost on the whole team.

[Satish, 2012-02-07 23:29:54]

On 2012/02/07 23:23:16, John Abd-El-Malek wrote:
> I understand why there might be an android version of image_transport_surface,
> since android is a platform and we have versions for mac/win/linux.
> 
> But gpu_info_collector_android.cc appears to be just android stubs for a cc
file
> that's shared among all existing platforms. Adding stub files for android is a
> maintenance cost on the whole team.

Would it be acceptable to drop the stubs and instead add
#if defined(OS_ANDROID)
  return true;
#endif
?

[no sievers, 2012-02-07 23:34:58]

Actually, this only overwrites what linux, mac and win also all override
separately (in gpu_info_collector_linux/mac/win.cc).

[jam, 2012-02-07 23:38:24]

sorry guys, I misread this and didn't see that chrome also has per-platform
files, ignore the noise.

On Tue, Feb 7, 2012 at 3:29 PM, <satish@chromium.org> wrote:

> On 2012/02/07 23:23:16, John Abd-El-Malek wrote:
>
>> I understand why there might be an android version of
>> image_transport_surface,
>> since android is a platform and we have versions for mac/win/linux.
>>
>
> But gpu_info_collector_android.cc appears to be just android stubs for a cc
>>
> file
>
>> that's shared among all existing platforms. Adding stub files for android
>> is a
>> maintenance cost on the whole team.
>>
>
> Would it be acceptable to drop the stubs and instead add
> #if defined(OS_ANDROID)
>  return true;
> #endif
> ?



On Tue, Feb 7, 2012 at 3:34 PM, <sievers@chromium.org> wrote:

> Actually, this only overwrites what linux, mac and win also all override
> separately (in gpu_info_collector_linux/mac/**win.cc).
>
>
>
https://chromiumcodereview.**appspot.com/9348033/<https://chromiumcodereview....
>

[commit-bot: I haz the power, 2012-02-08 07:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satish@chromium.org/9348033/8001

[commit-bot: I haz the power, 2012-02-08 08:08:31]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 120949, job name
was 9348033-8001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[commit-bot: I haz the power, 2012-02-08 14:11:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satish@chromium.org/9348033/8001

[commit-bot: I haz the power, 2012-02-08 14:56:43]

Try job failure for 9348033-8001 (previous was lost) (retry) on win_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-08 15:43:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satish@chromium.org/9348033/8001

[commit-bot: I haz the power, 2012-02-08 16:07:41]

Try job failure for 9348033-8001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-08 17:37:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satish@chromium.org/9348033/8001

[commit-bot: I haz the power, 2012-02-08 19:41:45]

Change committed as 121023