Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: chrome/browser/chromeos/login/login_performer.cc

Issue 9348022: [cros] Use mocked URLFetcher and other mocks in ExistingUserController tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/login_display.h ('k') | chrome/browser/chromeos/login/login_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/login_performer.cc
diff --git a/chrome/browser/chromeos/login/login_performer.cc b/chrome/browser/chromeos/login/login_performer.cc
index ec814e909857996adc60cbb6b82cc10729516463..40c23b9972a42895f374e05bd587e19803fc7e8e 100644
--- a/chrome/browser/chromeos/login/login_performer.cc
+++ b/chrome/browser/chromeos/login/login_performer.cc
@@ -223,7 +223,10 @@ void LoginPerformer::OnPasswordChangeDetected() {
void LoginPerformer::OnChecked(const std::string& username, bool success) {
if (!delegate_) {
- NOTREACHED();
+ // Delegate is reset in case of successful offline login.
+ // See ExistingUserConstoller::OnLoginSuccess().
+ // Case when user has changed password and enters old password
+ // does not block user from sign in yet.
return;
}
delegate_->OnOnlineChecked(username, success);
« no previous file with comments | « chrome/browser/chromeos/login/login_display.h ('k') | chrome/browser/chromeos/login/login_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698