Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 9347052: Add minimal CalculateIdleState implementation for Android. (Closed)

Created:
8 years, 10 months ago by Yaron
Modified:
8 years, 10 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, tonyg
Visibility:
Public.

Description

Add minimal CalculateIdleState implementation for Android. It currently just reports that we're active on Android. Further revisions could check device state to see if we're active but on memory constrained devices such as Android we'll often get completely killed if Chrome isn't active. This is a minimal step towards linking Chrome on Android. BUG=113487 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122184

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A chrome/browser/idle_android.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yaron
8 years, 10 months ago (2012-02-15 21:28:36 UTC) #1
John Grabowski
Plz add much of the CL description as comments in the code. Add a TODO(yaron) ...
8 years, 10 months ago (2012-02-15 21:48:31 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-15 21:57:26 UTC) #3
John Grabowski
LGTM
8 years, 10 months ago (2012-02-15 22:04:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9347052/4
8 years, 10 months ago (2012-02-15 22:05:58 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 23:30:38 UTC) #6
Change committed as 122184

Powered by Google App Engine
This is Rietveld 408576698