Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 9345004: Remove the Create Application Shortcut... menu item (Closed)

Created:
8 years, 10 months ago by sail
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove the Create Application Shortcut... menu item This menu item is always disabled. Remove it. xib changes: removed the menu item from the File menu Note, jeremy@ and I are working on apps for Mac so hopefully we'll add a working implementation. BUG=13148 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -47 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 11 chunks +3 lines, -39 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sail
8 years, 10 months ago (2012-02-06 22:54:01 UTC) #1
Nico
LGTM Say BUG=13148 and mention in the description that 'apps v2 will cover this, on ...
8 years, 10 months ago (2012-02-06 23:01:14 UTC) #2
sail
updated change summary
8 years, 10 months ago (2012-02-06 23:17:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9345004/1
8 years, 10 months ago (2012-02-06 23:21:07 UTC) #4
commit-bot: I haz the power
Presubmit check for 9345004-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-06 23:21:11 UTC) #5
sail
+pkasting: ui/* OWNERS review
8 years, 10 months ago (2012-02-06 23:24:14 UTC) #6
Peter Kasting
OWNERS LGTM
8 years, 10 months ago (2012-02-06 23:25:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9345004/1
8 years, 10 months ago (2012-02-06 23:42:27 UTC) #8
commit-bot: I haz the power
Try job failure for 9345004-1 (retry) (previous was lost) on mac_rel for step "ui_tests". It's ...
8 years, 10 months ago (2012-02-07 04:18:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9345004/1
8 years, 10 months ago (2012-02-07 04:20:48 UTC) #10
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 07:00:37 UTC) #11
Change committed as 120734

Powered by Google App Engine
This is Rietveld 408576698