Make the Chrome Web Store Icon Syncable

chrome/common/extensions/extension.cc

Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 04475081a52ddc8d892092fde25f1caeb48a4a19..5e72e4923758f9c8ae7ed745bd22dfdbfb7c4919 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -2971,6 +2971,13 @@ bool Extension::OverlapsWithOrigin(const GURL& origin) const {
 }
 
 Extension::SyncType Extension::GetSyncType() const {
+  // The CWS needs to be treated as syncable app because it appears on the NTP
+  // and we need to make sure its position values are synced.
+  // If another case arises where we need to have a special case like the CWS,
+  // something more systematic should be done.
+  if (id() == extension_misc::kWebStoreAppId)

[Aaron Boodman, 2012/02/08 00:37:53]

Perhaps a better test would be:

return extension->location() == Extension::INTERNAL || extension->IsApp() ?

Do all loaded apps show up in launcher, or only ones that are location() ==
INTERNAL, or what?

[csharp, 2012/02/08 15:46:16]

I'm fairly certain that all loaded apps will appear on the NTP, so I've modify
the check to not return SYNC_TYPE_NONE for app (since we will want to sync the
ordinals). 

akalin, does this seems reasonable to you?

[csharp, 2012/02/08 16:43:33]

Ok, so not all loaded apps appear in the app launch (cloud print is an app and
doesn't appear). This change cause the cloud print app to be synced, which I
don't think it should be. I've reverted this back to just treating the webstore
different here, because otherwise I think I'll end up with a  lot of other
places where the cloud print app needs to be treated differently.

+    return SYNC_TYPE_APP;
+
   // TODO(akalin): Figure out if we need to allow some other types.
   if (location() != Extension::INTERNAL) {
     // We have a non-standard location.