Make the Chrome Web Store Icon Syncable

chrome/common/extensions/extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include <algorithm>
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 2953 matching lines @@
   origin_only_pattern.SetHost(origin.host());
   origin_only_pattern.SetPath("/*");
 
   URLPatternSet origin_only_pattern_list;
   origin_only_pattern_list.AddPattern(origin_only_pattern);
 
   return web_extent().OverlapsWith(origin_only_pattern_list);
 }
 
 Extension::SyncType Extension::GetSyncType() const {
+  // The CWS needs to be treated as syncable app because it appears on the NTP
+  // and we need to make sure its position values are synced.
+  // If another case arises where we need to have a special case like the CWS,
+  // something more systematic should be done.
+  if (id() == extension_misc::kWebStoreAppId)

[Aaron Boodman, 2012/02/08 00:37:53]

Perhaps a better test would be:

return extension->location() == Extension::INTERNAL || extension->IsApp() ?

Do all loaded apps show up in launcher, or only ones that are location() ==
INTERNAL, or what?

[csharp, 2012/02/08 15:46:16]

I'm fairly certain that all loaded apps will appear on the NTP, so I've modify
the check to not return SYNC_TYPE_NONE for app (since we will want to sync the
ordinals). 

akalin, does this seems reasonable to you?

[csharp, 2012/02/08 16:43:33]

Ok, so not all loaded apps appear in the app launch (cloud print is an app and
doesn't appear). This change cause the cloud print app to be synced, which I
don't think it should be. I've reverted this back to just treating the webstore
different here, because otherwise I think I'll end up with a  lot of other
places where the cloud print app needs to be treated differently.

+    return SYNC_TYPE_APP;
+
   // TODO(akalin): Figure out if we need to allow some other types.
   if (location() != Extension::INTERNAL) {
     // We have a non-standard location.
     return SYNC_TYPE_NONE;
   }
 
   // Disallow extensions with non-gallery auto-update URLs for now.
   //
   // TODO(akalin): Relax this restriction once we've put in UI to
   // approve synced extensions.
@@ skipping 63 matching lines @@
     already_disabled(false),
     extension(extension) {}
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const ExtensionPermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}