ui/gfx: Make the first version of Canvas::TileImageInt take a gfx::Rect.

chrome/browser/ui/views/tabs/tab.cc

Index: chrome/browser/ui/views/tabs/tab.cc
diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc
index 34236eccbaa71c370817d981516681a979d0b0d3..b9bf0e45289f99a327a063800b8badc601e92c45 100644
--- a/chrome/browser/ui/views/tabs/tab.cc
+++ b/chrome/browser/ui/views/tabs/tab.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -486,11 +486,11 @@ void Tab::PaintInactiveTabBackground(gfx::Canvas* canvas) {
 
   // Now draw the highlights/shadows around the tab edge.
   canvas->DrawBitmapInt(*tab_inactive_image->image_l, 0, 0);
-  canvas->TileImageInt(*tab_inactive_image->image_c,
-                       tab_inactive_image->l_width, 0,
-                       width() - tab_inactive_image->l_width -
-                           tab_inactive_image->r_width,
-                       height());
+  canvas->TileImage(*tab_inactive_image->image_c,

[Peter Kasting, 2012/02/06 22:32:39]

Nit: Shorter:

  gfx::Rect tile_rect(GetLocalBounds());
  tile_rect.Inset(tab_inactive_image->l_width, 0, tab_inactive_image->r_width,
                  0);
  canvas->TileImage(*tab_inactive_image->image_c, tile_rect);
  canvas->DrawBitmapInt(*tab_inactive_image->image_r, tile_rect.right(), 0);

[tfarina, 2012/02/06 23:12:16]

Done.

+                    gfx::Rect(tab_inactive_image->l_width, 0,
+                              width() - tab_inactive_image->l_width -
+                                  tab_inactive_image->r_width,
+                              height()));
   canvas->DrawBitmapInt(*tab_inactive_image->image_r,
                         width() - tab_inactive_image->r_width, 0);
 }
@@ -531,8 +531,8 @@ void Tab::PaintActiveTabBackground(gfx::Canvas* canvas) {
 
   // Now draw the highlights/shadows around the tab edge.
   canvas->DrawBitmapInt(*tab_image->image_l, 0, 0);
-  canvas->TileImageInt(*tab_image->image_c, tab_image->l_width, 0,
-      width() - tab_image->l_width - tab_image->r_width, height());
+  canvas->TileImage(*tab_image->image_c, gfx::Rect(tab_image->l_width, 0,

[Peter Kasting, 2012/02/06 22:32:39]

Nit: Possibly clearer:

  gfx::Rect tile_rect(GetLocalBounds());
  tile_rect.Inset(tab_image->l_width, 0, tab_image->r_width, 0);
  canvas->TileImage(*tab_image->image_c, tile_rect);
  canvas->DrawBitmapInt(*tab_image->image_r, tile_rect.right(), 0);

[tfarina, 2012/02/06 23:12:16]

Done.

+      width() - tab_image->l_width - tab_image->r_width, height()));
   canvas->DrawBitmapInt(*tab_image->image_r, width() - tab_image->r_width, 0);
 }