Improving the decoder pipeline.

remoting/client/plugin/chromoting_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_instance.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 179 matching lines @@
     LOG(ERROR) << "Media library not initialized.";
     return false;
   }
 
   // Start all the threads.
   context_.Start();
 
   // Create the chromoting objects that don't depend on the network connection.
   // Because we decode on a separate thread we need a FrameConsumerProxy to
   // bounce calls from the RectangleUpdateDecoder back to the plugin thread.
-  view_.reset(new PepperView(this, &context_));
-  consumer_proxy_ = new FrameConsumerProxy(view_.get(), plugin_message_loop_);
+  consumer_proxy_ = new FrameConsumerProxy(plugin_message_loop_);
   rectangle_decoder_ = new RectangleUpdateDecoder(
       context_.decode_message_loop(), consumer_proxy_.get());
-
-  // Default to a medium grey.
-  view_->SetSolidFill(0xFFCDCDCD);
+  view_.reset(new PepperView(this, &context_, rectangle_decoder_.get()));
+  consumer_proxy_->Attach(view_.get());
 
   return true;
 }
 
 void ChromotingInstance::HandleMessage(const pp::Var& message) {
   if (!message.is_string()) {
     LOG(ERROR) << "Received a message that is not a string.";
     return;
   }
 
@@ skipping 37 matching lines @@
   } else if (method == "releaseAllKeys") {
     ReleaseAllKeys();
   }
 }
 
 void ChromotingInstance::DidChangeView(const pp::Rect& position,
                                        const pp::Rect& clip) {
   DCHECK(plugin_message_loop_->BelongsToCurrentThread());
 
   SkISize new_size = SkISize::Make(position.width(), position.height());
-  if (view_->SetViewSize(new_size)) {
-    if (mouse_input_filter_.get()) {
-      mouse_input_filter_->set_input_size(new_size);
-    }
-    rectangle_decoder_->SetOutputSize(new_size);
+  SkIRect new_clip =
+    SkIRect::MakeXYWH(clip.x(), clip.y(), clip.width(), clip.height());
+
+  view_->SetView(new_size, new_clip);
+
+  if (mouse_input_filter_.get()) {
+    mouse_input_filter_->set_input_size(view_->get_view_size());
   }
-
-  rectangle_decoder_->UpdateClipRect(
-      SkIRect::MakeXYWH(clip.x(), clip.y(), clip.width(), clip.height()));
 }
 
 bool ChromotingInstance::HandleInputEvent(const pp::InputEvent& event) {
   DCHECK(plugin_message_loop_->BelongsToCurrentThread());
 
   if (!input_handler_.get())
     return false;
 
   // TODO(wez): When we have a good hook into Host dimensions changes, move
   // this there.
   // If |input_handler_| is valid, then |mouse_input_filter_| must also be
   // since they are constructed together as part of the input pipeline
-  mouse_input_filter_->set_output_size(view_->get_host_size());
+  mouse_input_filter_->set_output_size(view_->get_screen_size());
 
   return input_handler_->HandleInputEvent(event);
 }
 
 pp::Var ChromotingInstance::GetInstanceObject() {
   if (instance_object_.is_undefined()) {
     ChromotingScriptableObject* object =
         new ChromotingScriptableObject(this, plugin_message_loop_);
     object->Init();
 
@@ skipping 246 matching lines @@
     scoped_ptr<base::DictionaryValue> data(new base::DictionaryValue());
     data->SetString("message", message);
     PostChromotingMessage("logDebugMessage", data.Pass());
 
     scriptable_object->LogDebugInfo(message);
   }
   g_logging_to_plugin = false;
 }
 
 }  // namespace remoting