Move the thread local functions to the Thread class in runtime/platform

runtime/platform/thread_linux.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/thread.h"
 
 #include <errno.h>
 #include <sys/time.h>
 
 #include "platform/assert.h"
@@ skipping 85 matching lines @@
   result = pthread_create(&tid, &attr, ThreadStart, data);
   RETURN_ON_PTHREAD_FAILURE(result);
 
   result = pthread_attr_destroy(&attr);
   RETURN_ON_PTHREAD_FAILURE(result);
 
   return 0;
 }
 
 
+ThreadLocalKey Thread::kInvalidThreadLocal = static_cast<pthread_key_t>(-1);
+
+
+ThreadLocalKey Thread::CreateThreadLocal() {
+  pthread_key_t key = kInvalidThreadLocal;
+  int result = pthread_key_create(&key, NULL);

[siva, 2012/02/06 19:29:37]

ASSERT(key != kInvalidThreadLocal);

[Søren Gjesse, 2012/02/07 09:13:59]

Done.

+  VALIDATE_PTHREAD_RESULT(result);
+  return key;
+}
+
+
+void Thread::DeleteThreadLocal(ThreadLocalKey key) {
+  ASSERT(key != kInvalidThreadLocal);
+  int result = pthread_key_delete(key);
+  VALIDATE_PTHREAD_RESULT(result);
+}
+
+
+uword Thread::GetThreadLocal(ThreadLocalKey key) {
+  ASSERT(key != kInvalidThreadLocal);
+  return reinterpret_cast<uword>(pthread_getspecific(key));
+}

[siva, 2012/02/06 19:29:37]

Can this be defined in the header file so that it gets inlined the way it is
now.

[Søren Gjesse, 2012/02/07 09:13:59]

Added a class ThreadInlineImpl to platform specific .h files with static method
for GetThreadLocal. We could consider just moving all of class Thread to the
platform specific .h files.

+
+
+void Thread::SetThreadLocal(ThreadLocalKey key, uword value) {
+  ASSERT(key != kInvalidThreadLocal);
+  int result = pthread_setspecific(key, reinterpret_cast<void*>(value));
+  VALIDATE_PTHREAD_RESULT(result);
+}
+
+
 Mutex::Mutex() {
   pthread_mutexattr_t attr;
   int result = pthread_mutexattr_init(&attr);
   VALIDATE_PTHREAD_RESULT(result);
 
 #if defined(DEBUG)
   result = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ERRORCHECK);
   VALIDATE_PTHREAD_RESULT(result);
 #endif  // defined(DEBUG)
 
@@ skipping 124 matching lines @@
 }
 
 
 void Monitor::NotifyAll() {
   // TODO(iposva): Do we need to track lock owners?
   int result = pthread_cond_broadcast(data_.cond());
   VALIDATE_PTHREAD_RESULT(result);
 }
 
 }  // namespace dart