chrome/common/extensions/api/windows.json - Issue 9328037: Add fullscreen state support for chrome.windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/windows.json

Issue 9328037: Add fullscreen state support for chrome.windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Separate FullscreenController related stuff to another patch set Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/common/extensions/docs/samples.json » ('j') | chrome/test/data/extensions/api_test/window_update/show_state/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/windows.json

diff --git a/chrome/common/extensions/api/windows.json b/chrome/common/extensions/api/windows.json

index e72f30345ee0af11419851f1d04327e564cb184a..e322e025845b3ef5a0a48334766f036254921425 100644

--- a/chrome/common/extensions/api/windows.json

+++ b/chrome/common/extensions/api/windows.json

@@ -23,7 +23,7 @@

"state": {

"type": "string",

"description": "The state of this browser window.",

- "enum": ["normal", "minimized", "maximized"]

+ "enum": ["normal", "minimized", "maximized", "fullscreen"]

}

@@ -208,8 +208,8 @@

"state": {

"type": "string",

"optional": true,

- "description": "The new state of the window. The 'minimized' and 'maximized' states cannot be combined with 'left', 'top', 'width' or 'height'.",

- "enum": ["normal", "minimized", "maximized"]

+ "description": "The new state of the window. The 'minimized', 'maximized' and 'fullscreen' states cannot be combined with 'left', 'top', 'width' or 'height'.",

+ "enum": ["normal", "minimized", "maximized", "fullscreen"]

}