Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 9325085: Move utils/{uri, utf8} to lib/{uri, utf8} . (Closed)

Created:
8 years, 10 months ago by dgrove
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move utils/{uri, utf8} to lib/{uri, utf8} . Fixes issue 1562 . Committed: https://code.google.com/p/dart/source/detail?r=4010

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -329 lines) Patch
M client/util/utilslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/frog_leg.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/leg.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/scanner/node_scanner_bench.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/scanner/scannerlib.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/scanner/vm_scanner_bench.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/leg/tools/mini_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/tests/leg/src/ScannerTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/tests/leg/src/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/tests/leg/src/parser_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/src/UriTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 3 chunks +29 lines, -22 lines 0 comments Download
D utils/uri/uri.dart View 1 chunk +0 lines, -215 lines 0 comments Download
D utils/utf8/utf8.dart View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgrove
8 years, 10 months ago (2012-02-06 20:52:25 UTC) #1
dgrove
8 years, 10 months ago (2012-02-06 21:31:27 UTC) #2
dgrove
codereview doesn't show directory moves correctly. The actual status is: M frog/tests/leg/src/ScannerTest.dart M frog/tests/leg/src/parser_helper.dart M ...
8 years, 10 months ago (2012-02-06 22:25:29 UTC) #3
dgrove
Add Siggi as a reviewer so that we can get this done quickly.
8 years, 10 months ago (2012-02-07 21:04:27 UTC) #4
Siggi Cherem (dart-lang)
I don't see the added files in the codereview either. Are they missing?
8 years, 10 months ago (2012-02-07 21:40:45 UTC) #5
dgrove
On 2012/02/07 21:40:45, sigmund wrote: > I don't see the added files in the codereview ...
8 years, 10 months ago (2012-02-07 21:41:36 UTC) #6
Siggi Cherem (dart-lang)
8 years, 10 months ago (2012-02-07 21:49:46 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698