Add token index position to classes and types for more accurate error reporting.

runtime/vm/class_finalizer.h

Index: runtime/vm/class_finalizer.h
===================================================================
--- runtime/vm/class_finalizer.h	(revision 3925)
+++ runtime/vm/class_finalizer.h	(working copy)
@@ -42,10 +42,8 @@
                                    AbstractType* conflicting);
 
   // Finalize and canonicalize type while parsing class cls.
-  // Set the error message on failure (to Error::null() if no error).
-  static RawAbstractType* FinalizeAndCanonicalizeType(const Class& cls,
-                                                      const AbstractType& type,
-                                                      Error* error);
+  static RawAbstractType* FinalizeType(const Class& cls,
+                                       const AbstractType& type);

[siva, 2012/02/06 18:13:08]

Why not call it FinalizeAndCanonicalizeType ?

[regis, 2012/02/06 19:43:16]

Not all types are canonicalized (e.g. ParameterType is not). The
"AndCanonicalize" suffix was used to differentiate the public version from the
private version of FinalizeType. We need only one version now and I picked the
more readable name. I have modified the comment about canonicalization. 

 
   // Pending classes are classes that need to be finalized.
   static void AddPendingClasses(const GrowableArray<const Class*>& classes);
@@ -82,8 +80,6 @@
   static void FinalizeTypeArguments(const Class& cls,
                                     const AbstractTypeArguments& arguments);
   static void ResolveType(const Class& cls, const AbstractType& type);
-  static RawAbstractType* FinalizeType(const Class& cls,
-                                       const AbstractType& type);
   static void ResolveAndFinalizeUpperBounds(const Class& cls);
   static void VerifyUpperBounds(const Class& cls,
                                 const AbstractTypeArguments& arguments);