Add token index position to classes and types for more accurate error reporting.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
 #include "vm/thread.h"
@@ skipping 1477 matching lines @@
 
   // Invoke a function which returns an object of type NativeFields.
   result = Dart_InvokeStatic(lib,
                              Dart_NewString("NativeFieldsTest"),
                              Dart_NewString("testMain"),
                              0,
                              NULL);
   // We expect the test script to fail finalization with the error below:
   EXPECT(Dart_IsError(result));
   Dart_Handle expected_error = Dart_Error(
-      "'dart:test-lib': Error: class 'NativeFields' is trying to extend a "
-      "native fields class, but library '%s' has no native resolvers",
-      TestCase::url());
-  EXPECT_STREQ(Dart_GetError(expected_error), Dart_GetError(result));
+      "'dart:test-lib': Error: line 1 pos 38: class 'NativeFields' is trying");

[siva, 2012/02/06 18:13:08]

Why did you chop of the rest of the error regarding library not having native
resolvers. I think that is a useful test which validates we are not finding
native resolvers.

[regis, 2012/02/06 19:43:16]

The emitted error message is now much longer, since it contains the exact
position as well as a snippet of the faulty code. I think that verifying only a
prefix of the error message is sufficient. Otherwise, I would have to copy
multiple lines of output in this test. I can make the prefix longer if you think
it is not testing enough in its current form.

[regis, 2012/02/06 20:07:48]

As discussed, I will not chop off the error message so short  as to test the
library url. I'll send you a cl.

+  EXPECT_SUBSTRING(Dart_GetError(expected_error), Dart_GetError(result));
 }
 
 
 static void TestNativeFields(Dart_Handle retobj) {
   // Access and set various instance fields of the object.
   Dart_Handle result = Dart_GetInstanceField(retobj, Dart_NewString("fld3"));
   EXPECT(Dart_IsError(result));
   result = Dart_GetInstanceField(retobj, Dart_NewString("fld0"));
   EXPECT_VALID(result);
   EXPECT(Dart_IsNull(result));
@@ skipping 1705 matching lines @@
   // We should have received the expected number of interrupts.
   EXPECT_EQ(kInterruptCount, interrupt_count);
 
   // Give the spawned thread enough time to properly exit.
   Isolate::SetInterruptCallback(saved);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart