Refactor PipelineIntegrationTest into PipelineIntegrationTestBase.

Refactor PipelineIntegrationTest into PipelineIntegrationTestBase.

No changes, just splits current framework out into
PipelineIntegrationTestBase.

BUG=112321
TEST=media_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120736

[DaleCurtis, 2012-02-03 20:54:44]

First cut at refactoring. Thoughts?

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
File media/filters/pipeline_integration_test_base.cc (right):

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
media/filters/pipeline_integration_test_base.cc:139:
scoped_ptr<FilterCollection>
PipelineIntegrationTestBase::CreateFilterCollection(
Unsure what the proper formatting for this should be. Ideas?

[acolwell GONE FROM CHROMIUM, 2012-02-03 22:28:59]

LGTM

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
File media/filters/pipeline_integration_test_base.cc (right):

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
media/filters/pipeline_integration_test_base.cc:139:
scoped_ptr<FilterCollection>
PipelineIntegrationTestBase::CreateFilterCollection(
On 2012/02/03 20:54:44, DaleCurtis wrote:
> Unsure what the proper formatting for this should be. Ideas?
I think line break on the return type and then again on before the first param
if needed.

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
File media/filters/pipeline_integration_test_base.h (right):

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
media/filters/pipeline_integration_test_base.h:31: void
OnStatusCallback(PipelineStatus expected_status,
I think this, OnEnded, QuitOnStatusCB, QuitAfterCurrentTimeTask, and
CreateFilterCollection(scoped_ptr<DemuxerFactory> demuxer_factory) should all be
made private.

[DaleCurtis, 2012-02-06 19:26:32]

Is protected good enough?

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
File media/filters/pipeline_integration_test_base.cc (right):

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
media/filters/pipeline_integration_test_base.cc:139:
scoped_ptr<FilterCollection>
PipelineIntegrationTestBase::CreateFilterCollection(
On 2012/02/03 22:28:59, acolwell wrote:
> On 2012/02/03 20:54:44, DaleCurtis wrote:
> > Unsure what the proper formatting for this should be. Ideas?
> I think line break on the return type and then again on before the first param
> if needed.
> 

Done.

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
File media/filters/pipeline_integration_test_base.h (right):

https://chromiumcodereview.appspot.com/9323044/diff/1/media/filters/pipeline_...
media/filters/pipeline_integration_test_base.h:31: void
OnStatusCallback(PipelineStatus expected_status,
On 2012/02/03 22:28:59, acolwell wrote:
> I think this, OnEnded, QuitOnStatusCB, QuitAfterCurrentTimeTask, and
> CreateFilterCollection(scoped_ptr<DemuxerFactory> demuxer_factory) should all
be
> made private.

I made them protected. If private then TestSeekDuringRead() can't hook into
OnEnded, QuitOnStatusCB.

[acolwell GONE FROM CHROMIUM, 2012-02-06 20:31:48]

On 2012/02/06 19:26:32, DaleCurtis wrote:
> Is protected good enough?
> 
protected is fine. LGTM v2

[commit-bot: I haz the power, 2012-02-06 21:20:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/9323044/6003

[commit-bot: I haz the power, 2012-02-06 22:47:18]

Try job failure for 9323044-6003 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-02-07 03:30:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/9323044/16001

[commit-bot: I haz the power, 2012-02-07 07:04:56]

Change committed as 120736