Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 9323030: Small fix for package_management on Mac OS X. (Closed)

Created:
8 years, 10 months ago by chrisha
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Small fix for package_management on Mac OS X. For some reason, on Mac setup_tools won't create the installation directory if it doesn't exist, while it appears to do so on Linux and Windows. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M package_management.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
chrisha
(I finally got a hold of a Mac so I can test on Mac, Linux ...
8 years, 10 months ago (2012-02-03 14:50:57 UTC) #1
Marc-Antoine Ruel (Google)
lgtm
8 years, 10 months ago (2012-02-03 15:01:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/9323030/1
8 years, 10 months ago (2012-02-03 15:01:51 UTC) #3
commit-bot: I haz the power
Presubmit check for 9323030-1 failed and returned exit status 1. warning: code.google.com certificate with fingerprint ...
8 years, 10 months ago (2012-02-03 15:07:45 UTC) #4
chrisha
I need a lgtm from your chromium.org account; your google.com account is not listed in ...
8 years, 10 months ago (2012-02-03 15:14:51 UTC) #5
M-A Ruel
lgtm
8 years, 10 months ago (2012-02-03 15:26:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/9323030/1
8 years, 10 months ago (2012-02-03 15:26:19 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-03 15:32:29 UTC) #8
Change committed as 120331

Powered by Google App Engine
This is Rietveld 408576698