[Sync] - In about:sync page display if the first sync after restart has taken place or not.

chrome/browser/sync/internal_api/sync_manager.h

Index: chrome/browser/sync/internal_api/sync_manager.h
diff --git a/chrome/browser/sync/internal_api/sync_manager.h b/chrome/browser/sync/internal_api/sync_manager.h
index f0ece708c8126ffb3aab36519f88a0703ecdde49..a43689beff95e6f2d313434c2f992290d45b80e4 100644
--- a/chrome/browser/sync/internal_api/sync_manager.h
+++ b/chrome/browser/sync/internal_api/sync_manager.h
@@ -94,6 +94,8 @@ class SyncManager {
       // The internal instance is in an unrecognizable state. This should not
       // happen.
       INVALID = 0,
+      // A sync has not happened since restart.
+      UNININITIALIZED,

[rlarocque, 2012/02/02 22:44:13]

I no longer think this is a good name.  It makes sense in this context
(especially in the constructor's member initializers) but not in about:sync.  I
worry it could be misinterpreted as meaning that the sync service is not
initialized, as opposed to indicating that the sync status has not been
initialized.  

Maybe UNKNOWN would be a better choice?

Sorry about the flip-flop.

[lipalani1, 2012/02/03 01:55:39]

our target audience is:
1. We expect only developers to see this. But the developer need not work on
chrome sync or he could just be a chrome committer.
What I have done is the status text would read READY but the description would
read there has been no sync since restart so the following values are
speculative.

With that in mind I think UNINITIALIZED looks to be a reasonably right name for
this enum.
On 2012/02/02 22:44:13, rlarocque wrote:

       // Can't connect to server, but there are no pending changes in
       // our local cache.
       OFFLINE,
@@ -104,8 +106,10 @@ class SyncManager {
       SYNCING,
       // Connected, no pending changes.
       READY,
-      // Can't connect to server, and we haven't completed the initial
-      // sync yet.  So there's nothing we can do but wait for the server.
+      // Can't connect to server.
+      // So there's nothing we can do but wait for the server.
+      // This state indicates there are no pending changes. Client
+      // is trying to sync possibly because of a notification.
       OFFLINE_UNUSABLE,
 
       SUMMARY_STATUS_COUNT,
@@ -137,8 +141,6 @@ class SyncManager {
     int conflicting_count;
 
     bool syncing;
-    // True after a client has done a first sync.
-    bool initial_sync_ended;
 
     // Total updates available.  If zero, nothing left to download.
     int64 updates_available;
@@ -160,6 +162,9 @@ class SyncManager {
     int useless_sync_cycles;
     int useful_sync_cycles;
 
+    // Sync cycle count.
+    int sync_count;
+
     // Encryption related.
     syncable::ModelTypeSet encrypted_types;
     bool cryptographer_ready;