[Sync] - In about:sync page display if the first sync after restart has taken place or not.

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1019 matching lines @@
 const GoogleServiceAuthError& ProfileSyncService::GetAuthError() const {
   return last_auth_error_;
 }
 
 bool ProfileSyncService::SetupInProgress() const {
   return !HasSyncSetupCompleted() && WizardIsVisible();
 }
 
 std::string ProfileSyncService::BuildSyncStatusSummaryText(
     const sync_api::SyncManager::Status::Summary& summary) {
-  const char* strings[] = {"INVALID", "OFFLINE", "OFFLINE_UNSYNCED", "SYNCING",
-      "READY", "OFFLINE_UNUSABLE"};
+  const char* strings[] = {"INVALID", "READY", "OFFLINE", "OFFLINE_UNSYNCED",

[rlarocque, 2012/02/08 00:07:37]

This is much more clever than it ought to be.  No one will expect that the
enum-to-string method has been tweaked to return the same string for two
different enum values.  It's not very discoverable, either; one would have to
carefully examine the the definitions here and in the .h file to notice this.  

+      "SYNCING", "READY", "OFFLINE_UNUSABLE"};
   COMPILE_ASSERT(arraysize(strings) ==
                  sync_api::SyncManager::Status::SUMMARY_STATUS_COUNT,
                  enum_indexed_array);
   if (summary < 0 ||
       summary >= sync_api::SyncManager::Status::SUMMARY_STATUS_COUNT) {
     LOG(DFATAL) << "Illegal Summary Value: " << summary;
     return "UNKNOWN";
   }
   return strings[summary];
 }
@@ skipping 546 matching lines @@
              << "Unrecoverable error.";
   } else {
     DVLOG(0) << "ConfigureDataTypeManager not invoked because backend is not "
              << "initialized";
   }
 }
 
 const FailedDatatypesHandler& ProfileSyncService::failed_datatypes_handler() {
   return failed_datatypes_handler_;
 }