webkit/tools/test_shell/simple_resource_loader_bridge.cc - Issue 9321003: net: Make UploadData::GetContentLength() asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/simple_resource_loader_bridge.cc

Issue 9321003: net: Make UploadData::GetContentLength() asynchronous. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/test_shell/simple_resource_loader_bridge.cc

diff --git a/webkit/tools/test_shell/simple_resource_loader_bridge.cc b/webkit/tools/test_shell/simple_resource_loader_bridge.cc

index 1dd138e1ba85433b56e0f66af7742c6527111410..49a311e91f235747cfa8ba57b2c64050b5e717b9 100644

--- a/webkit/tools/test_shell/simple_resource_loader_bridge.cc

+++ b/webkit/tools/test_shell/simple_resource_loader_bridge.cc

@@ -534,7 +534,9 @@ class RequestProxy : public net::URLRequest::Delegate,

return;

}

- uint64 size = request_->get_upload()->GetContentLength();

+ // GetContentLengthSync() may perform file IO, but it's ok here, as file

+ // IO is not prohibited in IOThread defined in the file.

+ uint64 size = request_->get_upload()->GetContentLengthSync();

uint64 position = request_->GetUploadProgress();

if (position == last_upload_position_)

return; // no progress made since last time