Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 9320051: Fix JavaScript style in ntp4 (Closed)

Created:
8 years, 10 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix JavaScript style in ntp4 BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120664

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/browser/resources/ntp4/most_visited_page.js View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp4/nav_dot.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/page_list_view.js View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp4/page_switcher.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/tile_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/trash.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tyler Breisacher (Chromium)
8 years, 10 months ago (2012-02-02 23:40:04 UTC) #1
Evan Stade
lgtm https://chromiumcodereview.appspot.com/9320051/diff/1/chrome/browser/resources/ntp4/most_visited_page.js File chrome/browser/resources/ntp4/most_visited_page.js (right): https://chromiumcodereview.appspot.com/9320051/diff/1/chrome/browser/resources/ntp4/most_visited_page.js#newcode357 chrome/browser/resources/ntp4/most_visited_page.js:357: * list. is this how the linter tells ...
8 years, 10 months ago (2012-02-02 23:48:42 UTC) #2
Tyler Breisacher (Chromium)
https://chromiumcodereview.appspot.com/9320051/diff/1/chrome/browser/resources/ntp4/most_visited_page.js File chrome/browser/resources/ntp4/most_visited_page.js (right): https://chromiumcodereview.appspot.com/9320051/diff/1/chrome/browser/resources/ntp4/most_visited_page.js#newcode357 chrome/browser/resources/ntp4/most_visited_page.js:357: * list. The linter doesn't care either way. I ...
8 years, 10 months ago (2012-02-02 23:54:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9320051/3002
8 years, 10 months ago (2012-02-06 22:43:46 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 00:55:36 UTC) #5
Change committed as 120664

Powered by Google App Engine
This is Rietveld 408576698