media/base/yuv_convert.cc - Issue 9320025: Introducing a helper wrapper for YUV-to-RGB convertion and/or scaling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/yuv_convert.cc

Issue 9320025: Introducing a helper wrapper for YUV-to-RGB convertion and/or scaling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More review feedback. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/yuv_convert.cc

diff --git a/media/base/yuv_convert.cc b/media/base/yuv_convert.cc

index 8d5073bfc2bc25d4fe47181e82ff0cc085985b55..ed9bed4cc87e0c9a5bfba43171b3aa606fcdfd9b 100644

--- a/media/base/yuv_convert.cc

+++ b/media/base/yuv_convert.cc

@@ -335,8 +335,9 @@ void ScaleYUVToRGB32WithRect(const uint8* y_buf,

// Determine the parts of the Y, U and V buffers to interpolate.

int source_y_left = source_left >> kFractionBits;

- int source_y_right = (source_right >> kFractionBits) + 2;

- DCHECK(source_y_right <= source_width);

+ int source_y_right = std::min(

+ (source_right >> kFractionBits) + 2,

+ source_width + 1);

int source_uv_left = source_y_left / 2;

int source_uv_right = std::min(

« no previous file with comments | « no previous file | remoting/base/decoder_vp8.h » ('j') | no next file with comments »