Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 9320015: When translating a page, get the code and translation via HTTPS. (Closed)

Created:
8 years, 10 months ago by palmer
Modified:
8 years, 10 months ago
Reviewers:
MAD
CC:
chromium-reviews, Jorge Lucangeli Obes (Google), jschuh
Visibility:
Public.

Description

When translating a page, get the code and translation via HTTPS. For some reason, the error reporting page doesn't work over HTTPS yet. That's a separate bug, and when it is fixed we'll fix the last http: URL in this file. BUG=112236 TEST=browser_tests: TranslateManagerTest.*; translation still works, and reporting a translation error still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/translate/translate_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palmer
8 years, 10 months ago (2012-02-01 20:37:14 UTC) #1
MAD
LGTM Thanks! BYE MAD
8 years, 10 months ago (2012-02-01 20:42:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/9320015/1
8 years, 10 months ago (2012-02-01 20:43:01 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 22:26:28 UTC) #4
Change committed as 120113

Powered by Google App Engine
This is Rietveld 408576698