Panels not getting focus on Linux when expanded from API on Linux.

chrome/browser/ui/panels/panel_browser_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_window_gtk.h"
 
 #include "base/bind.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/gtk/browser_titlebar.h"
 #include "chrome/browser/ui/panels/panel.h"
@@ skipping 77 matching lines @@
   // Do not show an icon in the task bar.  Window operations such as close,
   // minimize etc. can only be done from the panel UI.
   gtk_window_set_skip_taskbar_hint(window(), TRUE);
 
   g_signal_connect(titlebar_widget(), "button-press-event",
                    G_CALLBACK(OnTitlebarButtonPressEventThunk), this);
   g_signal_connect(titlebar_widget(), "button-release-event",
                    G_CALLBACK(OnTitlebarButtonReleaseEventThunk), this);
 
   ui::WorkAreaWatcherX::AddObserver(this);
+  registrar_.Add(
+      this,
+      chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE,
+      content::Source<Panel>(panel_.get()));
 }
 
 bool PanelBrowserWindowGtk::GetWindowEdge(int x, int y, GdkWindowEdge* edge) {
   // Since panels are not resizable or movable by the user, we should not
   // detect the window edge for behavioral purposes.  The edge, if any,
   // is present only for visual aspects.
   return FALSE;
 }
 
 bool PanelBrowserWindowGtk::HandleTitleBarLeftMousePress(
@@ skipping 116 matching lines @@
     return BrowserWindowGtk::PANGO_MARKUP;
   } else {
     return BrowserWindowGtk::GetWindowTitle(title);
   }
 }
 
 void PanelBrowserWindowGtk::WorkAreaChanged() {
   panel_->manager()->OnDisplayChanged();
 }
 
+void PanelBrowserWindowGtk::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  if (type == chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE) {
+    bool accept_focus = (panel_->expansion_state() == Panel::EXPANDED);
+    gdk_window_set_accept_focus(
+        gtk_widget_get_window(GTK_WIDGET(window())), accept_focus);

[jennb, 2012/02/01 00:31:47]

This also disables focus for OVERFLOW and TITLE_ONLY. That's different from
previous behavior - checking that's intentional...

[prasadt, 2012/02/01 00:37:47]

Yes, its intentional.

+  } else {
+    BrowserWindowGtk::Observe(type, source, details);

[Dmitry Titov, 2012/02/01 01:30:57]

Having this method overridden looks dangerous. What if someone adds 'else if()'
in the future for the same type of notification that base class is expecting?
Don't know the better way out of my head... 

Maybe remove the NOTREACHED in base class and then remove 'else' here?

[prasadt, 2012/02/01 01:52:28]

Done. Makes sense now that the method is overridden in a derived class.

+  }
+}
+
 void PanelBrowserWindowGtk::ShowPanel() {
   Show();
 }
 
 void PanelBrowserWindowGtk::ShowPanelInactive() {
   ShowInactive();
 }
 
 gfx::Rect PanelBrowserWindowGtk::GetPanelBounds() const {
   return bounds_;
@@ skipping 28 matching lines @@
 
 void PanelBrowserWindowGtk::ClosePanel() {
   // Cancel any currently running animation since we're closing down.
   if (bounds_animator_.get())
     bounds_animator_.reset();
 
   Close();
 }
 
 void PanelBrowserWindowGtk::ActivatePanel() {
-  gdk_window_set_accept_focus(
-      gtk_widget_get_window(GTK_WIDGET(window())), TRUE);
   Activate();
 }
 
 void PanelBrowserWindowGtk::DeactivatePanel() {
   BrowserWindow* browser_window =
       panel_->manager()->GetNextBrowserWindowToActivate(panel_.get());
   if (browser_window) {
     browser_window->Activate();
   } else {
     Deactivate();
   }
-
-  if (panel_->expansion_state() == Panel::MINIMIZED) {
-    gdk_window_set_accept_focus(
-        gtk_widget_get_window(GTK_WIDGET(window())), FALSE);
-  }
 }
 
 bool PanelBrowserWindowGtk::IsPanelActive() const {
   return IsActive();
 }
 
 gfx::NativeWindow PanelBrowserWindowGtk::GetNativePanelHandle() {
   return GetNativeHandle();
 }
 
@@ skipping 475 matching lines @@
   }
 }
 
 bool NativePanelTestingGtk::IsWindowSizeKnown() const {
   return panel_browser_window_gtk_->window_size_known_;
 }
 
 bool NativePanelTestingGtk::IsAnimatingBounds() const {
   return panel_browser_window_gtk_->IsAnimatingBounds();
 }