Issue 9318012: ui/list.js: prevent from position calculation with wrong position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9318012: ui/list.js: prevent from position calculation with wrong position. (Closed)

Created:
8 years, 10 months ago by yoshiki

Modified:
8 years, 10 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui/list.js: prevent from position calculation with wrong position. cr.ui.List.ensureAllItemSizesInCache() has manipulate elements and it has sometimes changed the scroll position and/or the client height unexceptionally. To prevent it, this CL moves reading of the positions before ensureAllItemSizesInCache(). BUG=110140 TEST=manual on taskmanager. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120032

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/resources/shared/js/cr/ui/list.js	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/9318012/1

8 years, 10 months ago (2012-02-01 03:16:33 UTC) #3

Change committed as 120032

Expand Messages | Collapse Messages