Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 9317100: Use the correct Resource constructor for PPB_Font_Shared in the plugin process. (Closed)

Created:
8 years, 10 months ago by yzshen1
Modified:
8 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Use the correct Resource constructor for PPB_Font_Shared in the plugin process. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120744

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M ppapi/shared_impl/private/ppb_font_shared.h View 1 1 chunk +15 lines, -1 line 0 comments Download
M ppapi/shared_impl/private/ppb_font_shared.cc View 1 3 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yzshen1
Hi, Brett. Please take a look. Thanks!
8 years, 10 months ago (2012-02-03 23:27:57 UTC) #1
brettw
lgtm
8 years, 10 months ago (2012-02-06 19:28:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9317100/1003
8 years, 10 months ago (2012-02-06 19:28:38 UTC) #3
commit-bot: I haz the power
Try job failure for 9317100-1003 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 21:59:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9317100/1003
8 years, 10 months ago (2012-02-06 22:20:59 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-07 03:33:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9317100/1003
8 years, 10 months ago (2012-02-07 06:51:20 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 09:22:16 UTC) #8
Change committed as 120744

Powered by Google App Engine
This is Rietveld 408576698