Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: media/filters/ffmpeg_glue.h

Issue 9317096: Fix media code to work with new ffmpeg. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix deprecated methods. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_glue.h
diff --git a/media/filters/ffmpeg_glue.h b/media/filters/ffmpeg_glue.h
index 257915eecb6ad3c1b30e460e700a4a61875f2f9a..88fa794c32533d4793758adb722c75f9bf88ad79 100644
--- a/media/filters/ffmpeg_glue.h
+++ b/media/filters/ffmpeg_glue.h
@@ -4,11 +4,11 @@
// FFmpegGlue is an adapter for FFmpeg's URLProtocol interface that allows us to
// use a DataSource implementation with FFmpeg. For convenience we use FFmpeg's
-// av_open_input_file function, which analyzes the filename given to it and
+// avformat_open_input function, which analyzes the filename given to it and
scherkus (not reviewing) 2012/02/06 21:13:49 nit: mind annotating the function calls in comment
DaleCurtis 2012/02/07 19:09:13 Done.
// automatically initializes the appropriate URLProtocol.
//
-// Since the DataSource is already open by time we call av_open_input_file, we
-// need a way for av_open_input_file to find the correct DataSource instance.
+// Since the DataSource is already open by time we call avformat_open_input, we
+// need a way for avformat_open_input to find the correct DataSource instance.
// The solution is to maintain a map of "filenames" to DataSource instances,
// where filenames are actually just a unique identifier. For simplicity,
// FFmpegGlue is registered as an HTTP handler and generates filenames based on
@@ -17,10 +17,10 @@
// thread-safe singleton.
//
// Usage: FFmpegDemuxer adds the DataSource to FFmpegGlue's map and is given a
-// filename to pass to av_open_input_file. FFmpegDemuxer calls
-// av_open_input_file with the filename, which results in FFmpegGlue returning
+// filename to pass to avformat_open_input. FFmpegDemuxer calls
+// avformat_open_input with the filename, which results in FFmpegGlue returning
// the DataSource as a URLProtocol instance to FFmpeg. Since FFmpegGlue is only
-// needed for opening files, when av_open_input_file returns FFmpegDemuxer
+// needed for opening files, when avformat_open_input returns FFmpegDemuxer
// removes the DataSource from FFmpegGlue's map.
#ifndef MEDIA_FILTERS_FFMPEG_GLUE_H_
@@ -90,7 +90,7 @@ class MEDIA_EXPORT FFmpegGlue {
virtual ~FFmpegGlue();
// Returns the unique key for this data source, which can be passed to
- // av_open_input_file as the filename.
+ // avformat_open_input as the filename.
std::string GetProtocolKey(FFmpegURLProtocol* protocol);
// Mutual exclusion while adding/removing items from the map.

Powered by Google App Engine
This is Rietveld 408576698