chrome/renderer/extensions/custom_bindings_util.cc - Issue 9317072: Allow omitting optional parameters for Extensions API functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/custom_bindings_util.cc

Issue 9317072: Allow omitting optional parameters for Extensions API functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Better error message distinguishing signature errors and type validation errors. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/custom_bindings_util.cc

diff --git a/chrome/renderer/extensions/custom_bindings_util.cc b/chrome/renderer/extensions/custom_bindings_util.cc

index 5d9277f431fe8f174d0b214b52323c374c58e97f..dc2b53d420348d72f4528274da4bd62118e08133 100644

--- a/chrome/renderer/extensions/custom_bindings_util.cc

+++ b/chrome/renderer/extensions/custom_bindings_util.cc

@@ -42,7 +42,6 @@ std::vector<v8::Extension*> GetAll(ExtensionDispatcher* extension_dispatcher) {

"extensions/storage_custom_bindings.js",

"extensions/tts_engine_custom_bindings.js",

"extensions/types_custom_bindings.js",

- "extensions/windows_custom_bindings.js",

};

static const size_t kJavascriptFilesSize = arraysize(kJavascriptFiles);

@@ -58,7 +57,6 @@ std::vector<v8::Extension*> GetAll(ExtensionDispatcher* extension_dispatcher) {

IDR_STORAGE_CUSTOM_BINDINGS_JS,

IDR_TTS_ENGINE_CUSTOM_BINDINGS_JS,

IDR_TYPES_CUSTOM_BINDINGS_JS,

- IDR_WINDOWS_CUSTOM_BINDINGS_JS,

};

static const size_t kResourceIDsSize = arraysize(kResourceIDs);