Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 9317064: Stub in class for layout of network controls on the main settings page. (Closed)

Created:
8 years, 10 months ago by kevers
Modified:
8 years, 10 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Stub in class for layout of network controls on the main settings page. BUG=chromium:110749, chromium:112293 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120695

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix whitespace formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -0 lines) Patch
A chrome/browser/resources/options2/chromeos/network_list.js View 1 1 chunk +207 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kevers
Hi Chris, Can you have a look at this CL, which provides classes for grouping ...
8 years, 10 months ago (2012-02-02 22:29:18 UTC) #1
csilv
lgtm http://codereview.chromium.org/9317064/diff/1/chrome/browser/resources/options2/chromeos/network_list.js File chrome/browser/resources/options2/chromeos/network_list.js (right): http://codereview.chromium.org/9317064/diff/1/chrome/browser/resources/options2/chromeos/network_list.js#newcode167 chrome/browser/resources/options2/chromeos/network_list.js:167: NetworkList.refreshNetworkData = function (data) { nit: remove space ...
8 years, 10 months ago (2012-02-03 19:54:30 UTC) #2
kevers
http://codereview.chromium.org/9317064/diff/1/chrome/browser/resources/options2/chromeos/network_list.js File chrome/browser/resources/options2/chromeos/network_list.js (right): http://codereview.chromium.org/9317064/diff/1/chrome/browser/resources/options2/chromeos/network_list.js#newcode167 chrome/browser/resources/options2/chromeos/network_list.js:167: NetworkList.refreshNetworkData = function (data) { On 2012/02/03 19:54:30, csilv ...
8 years, 10 months ago (2012-02-06 17:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/9317064/3001
8 years, 10 months ago (2012-02-06 17:25:31 UTC) #4
commit-bot: I haz the power
Try job failure for 9317064-3001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 19:58:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/9317064/3001
8 years, 10 months ago (2012-02-06 20:11:03 UTC) #6
commit-bot: I haz the power
Try job failure for 9317064-3001 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...
8 years, 10 months ago (2012-02-06 23:42:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/9317064/3001
8 years, 10 months ago (2012-02-07 00:44:25 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 02:53:39 UTC) #9
Change committed as 120695

Powered by Google App Engine
This is Rietveld 408576698