Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 9317013: Add a centralized mechanism for whitelisting access to extension permissions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: merge TerminalPrivate api changes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc
diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
index 9db5ff91281ea85ff359da3fd9294f77fd072c55..91764153073c01e230862b465d42c5113fb12d6f 100644
--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc
+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
@@ -23,9 +23,6 @@ const char kCroshCommand[] = "/usr/bin/crosh";
// We make stubbed crosh just echo back input.
const char kStubbedCroshCommand[] = "cat";
-const char kPermissionError[] =
- "Extension does not have the permission to use this API";
-
const char* GetCroshPath() {
if (chromeos::system::runtime_environment::IsRunningOnChromeOS())
return kCroshCommand;
@@ -53,8 +50,6 @@ void NotifyProcessOutput(Profile* profile,
return;
}
- CHECK(TerminalExtensionHelper::AllowAccessToExtension(profile, extension_id));
-
base::ListValue args;
args.Append(new base::FundamentalValue(pid));
args.Append(new base::StringValue(output_type));
@@ -79,12 +74,6 @@ TerminalPrivateFunction::~TerminalPrivateFunction() {
}
bool TerminalPrivateFunction::RunImpl() {
- if (!TerminalExtensionHelper::AllowAccessToExtension(profile_,
- extension_id())) {
- error_ = kPermissionError;
- return false;
- }
-
return RunTerminalFunction();
}

Powered by Google App Engine
This is Rietveld 408576698