Add a centralized mechanism for whitelisting access to extension permissions.

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 579 matching lines @@
        i != api_perms.end(); ++i) {
     if (*i == ExtensionAPIPermission::kExperimental)
       continue;
 
     ExtensionAPIPermission* permission = info->GetByID(*i);
     const char* name = permission->name();
     StringValue* p = new StringValue(name);
     permissions->Clear();
     permissions->Append(p);
 
-    // Some permissions are only available to component hosted apps.
-    if (permission->is_component_only()) {
+    if (permission->should_enforce_whitelist()) {
       LoadAndExpectError(Manifest(manifest.get(), name),
                          errors::kPermissionNotAllowed,
                          Extension::INTERNAL);
+
+    // Some permissions are only available to component hosted apps.
+    } else if (permission->is_component_only()) {
+      LoadAndExpectError(Manifest(manifest.get(), name),
+                         errors::kPermissionNotAllowed,
+                         Extension::INTERNAL);
       scoped_refptr<Extension> extension(
           LoadAndExpectSuccess(Manifest(manifest.get(), name),
                                Extension::COMPONENT));
       EXPECT_TRUE(extension->GetActivePermissions()->HasAPIPermission(
           permission->id()));
 
     } else if (permission->type_restrictions() == platform_app) {
       LoadAndExpectError(Manifest(manifest.get(), name),
                          errors::kPermissionNotAllowed,
                          Extension::INTERNAL,
@@ skipping 443 matching lines @@
   EXPECT_EQ("", extension->page_action()->id());
   EXPECT_EQ(0u, extension->page_action()->icon_paths()->size());
   EXPECT_EQ("", extension->page_action()->GetTitle(
       ExtensionAction::kDefaultTabId));
   EXPECT_FALSE(extension->page_action()->HasPopup(
       ExtensionAction::kDefaultTabId));
 
   LoadAndExpectError("page_action_manifest_version_2b.json",
                      errors::kInvalidPageActionPopup);
 }