Add a centralized mechanism for whitelisting access to extension permissions.

chrome/browser/extensions/api/terminal/terminal_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/terminal/terminal_private_api.h"
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/process_proxy/process_proxy_registry.h"
 #include "chrome/browser/chromeos/system/runtime_environment.h"
 #include "chrome/browser/extensions/extension_event_names.h"
 #include "chrome/browser/extensions/extension_event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace {
 
 const char kCroshName[] = "crosh";
 const char kCroshCommand[] = "/usr/bin/crosh";
 // We make stubbed crosh just echo back input.
 const char kStubbedCroshCommand[] = "cat";
 
-const char kPermissionError[] =
-    "Extension does not have the permission to use this API";
-
-const char* kAllowedExtensionIds[] ={
-    "okddffdblfhhnmhodogpojmfkjmhinfp",  // test SSH/Crosh Client
-    "pnhechapfaindjhompbnflcldabbghjo"  // HTerm App
-};
-
-// Allow component and whitelisted extensions.
-bool AllowAccessToExtension(Profile* profile, const std::string& extension_id) {
-  ExtensionService* service = profile->GetExtensionService();
-  const Extension* extension = service->GetExtensionById(extension_id, false);
-
-  if (!extension)
-    return false;
-
-  if (extension->location() == Extension::COMPONENT)
-    return true;
-
-  for (size_t i = 0; i < arraysize(kAllowedExtensionIds); i++) {
-    if (extension->id() == kAllowedExtensionIds[i])
-      return true;
-  }
-  return false;
-}
-
 const char* GetCroshPath() {
   if (chromeos::system::runtime_environment::IsRunningOnChromeOS())
     return kCroshCommand;
   else
     return kStubbedCroshCommand;
 }
 
 const char* GetProcessCommandForName(const std::string& name) {
   if (name == kCroshName) {
     return GetCroshPath();
   } else {
     return NULL;
   }
 }
 
 void NotifyProcessOutput(Profile* profile,
                          const std::string& extension_id,
                          pid_t pid,
                          const std::string& output_type,
                          const std::string& output) {
   if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
     content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
         base::Bind(&NotifyProcessOutput, profile, extension_id,
                                          pid, output_type, output));
     return;
   }
 
-  CHECK(AllowAccessToExtension(profile, extension_id));
-
   base::ListValue args;
   args.Append(new base::FundamentalValue(pid));
   args.Append(new base::StringValue(output_type));
   args.Append(new base::StringValue(output));
 
   std::string args_json;
   base::JSONWriter::Write(&args, false /* pretty_print */, &args_json);
 
   if (profile && profile->GetExtensionEventRouter()) {
     profile->GetExtensionEventRouter()->DispatchEventToExtension(
         extension_id, extension_event_names::kOnTerminalProcessOutput,
         args_json, NULL, GURL());
   }
 }
 
 }  // namespace
 
 TerminalPrivateFunction::TerminalPrivateFunction() {
 }
 
 TerminalPrivateFunction::~TerminalPrivateFunction() {
 }
 
 bool TerminalPrivateFunction::RunImpl() {
-  if (!AllowAccessToExtension(profile_, extension_id())) {
-    error_ = kPermissionError;
-    return false;
-  }
-
   return RunTerminalFunction();
 }
 
 OpenTerminalProcessFunction::OpenTerminalProcessFunction() : command_(NULL) {
 }
 
 OpenTerminalProcessFunction::~OpenTerminalProcessFunction() {
 }
 
 bool OpenTerminalProcessFunction::RunTerminalFunction() {
@@ skipping 85 matching lines @@
 
   content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
       base::Bind(&CloseTerminalProcessFunction::RespondOnUIThread, this,
       success));
 }
 
 void CloseTerminalProcessFunction::RespondOnUIThread(bool success) {
   result_.reset(new base::FundamentalValue(success));
   SendResponse(true);
 }