Add a centralized mechanism for whitelisting access to extension permissions.

chrome/common/extensions/extension_permission_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_permission_set.h"
 
 #include <algorithm>
 #include <string>
 
+#include "base/command_line.h"

[Aaron Boodman, 2012/02/02 18:17:31]

Not needed.

[jstritar, 2012/02/03 14:33:17]

Woops, I do still need this. I added the command line check back to
IsWhitelisted.

 #include "base/memory/singleton.h"
 #include "base/values.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/common/chrome_switches.h"

[Aaron Boodman, 2012/02/02 18:17:31]

Not needed?

[jstritar, 2012/02/03 14:33:17]

ditto

 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_l10n_util.h"
 #include "chrome/common/extensions/url_pattern.h"
 #include "chrome/common/extensions/url_pattern_set.h"
 #include "content/public/common/url_constants.h"
 #include "grit/generated_resources.h"
 #include "net/base/registry_controlled_domain.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 35 matching lines @@
 const char* kNonPermissionFunctionNames[] = {
   "management.getPermissionWarningsByManifest",
   "tabs.create",
   "tabs.onRemoved",
   "tabs.remove",
   "tabs.update",
 };
 const size_t kNumNonPermissionFunctionNames =
     arraysize(kNonPermissionFunctionNames);
 
+// TODO(jstritar): We should find out what these extensions are.

[Aaron Boodman, 2012/02/02 18:17:31]

This is a pretty ominous comment :). Can you track down the people who added
these to the codebase (git log -S<id> will do it) and mail them and ask them to
add comments?

+
+// ExtensionAPIPermission::kTerminalPrivate whitelist.
+const char* kTerminalPrivateWhitelist[] = {
+  extension_misc::kHTermAppId,
+  extension_misc::kHTermDevAppId
+};
+
+// ExtensionAPIPermission::kWebSocketProxyPrivate whitelist.
+// ExtensionAPIPermission::kInputMethodPrivate whitelist.
+const char* kChromeOSWhitelist[] = {
+  "haiffjcadagjlijoggckpgfnoeiflnem",
+  "gnedhmakppccajfpfiihfcdlnpgomkcf",
+  "fjcibdnjlbfnbfdjneajpipnlcppleek",
+  extension_misc::kHTermAppId,
+  extension_misc::kHTermDevAppId
+};
+
+// ExtensionAPIPermission::kChromePrivate whitelist.
+const char* kChromePrivateWhitelist[] = {
+  "haiffjcadagjlijoggckpgfnoeiflnem",
+  "gnedhmakppccajfpfiihfcdlnpgomkcf",
+  "fjcibdnjlbfnbfdjneajpipnlcppleek"
+};
+
+// ExtensionAPIPermission::kChromeAuthPrivate whitelist.
+const char* kChromeAuthPrivateWhitelist[] = {
+  extension_misc::kCloudPrintAppId
+};
+
+// ExtensionAPIPermission::kWebstorePrivate whitelist.
+const char* kWebstorePrivateWhitelist[] = {
+  extension_misc::kEnterpriseWebStoreAppId,
+  extension_misc::kWebStoreAppId
+};
+
 const char kOldUnlimitedStoragePermission[] = "unlimited_storage";
 const char kWindowsPermission[] = "windows";
 
 void AddPatternsAndRemovePaths(const URLPatternSet& set, URLPatternSet* out) {
   DCHECK(out);
   for (URLPatternSet::const_iterator i = set.begin(); i != set.end(); ++i) {
     URLPattern p = *i;
     p.SetPath("/*");
     out->AddPattern(p);
   }
@@ skipping 110 matching lines @@
       kGeolocation, "geolocation", IDS_EXTENSION_PROMPT_WARNING_GEOLOCATION,
       ExtensionPermissionMessage::kGeolocation,
       kFlagCannotBeOptional, kTypeAll);
   info->RegisterPermission(
       kNotification, "notifications", 0,
       ExtensionPermissionMessage::kNone, kFlagNone, kTypeAll);
   info->RegisterPermission(
       kUnlimitedStorage, "unlimitedStorage", 0,
       ExtensionPermissionMessage::kNone, kFlagCannotBeOptional, kTypeAll);
 
-  // Register hosted app permissions that are also private.
-  info->RegisterPermission(
-      kChromePrivate, "chromePrivate", 0,
-      ExtensionPermissionMessage::kNone, kFlagCannotBeOptional,
-      kTypeAll - kTypePlatformApp);
-  info->RegisterPermission(
-      kChromeAuthPrivate, "chromeAuthPrivate", 0,
-      ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeAll - kTypePlatformApp);
-  info->RegisterPermission(
-      kWebstorePrivate, "webstorePrivate", 0,
-      ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeAll - kTypePlatformApp);
 
   // Register hosted and packaged app permissions.
   info->RegisterPermission(
       kAppNotifications, "appNotifications", 0,
       ExtensionPermissionMessage::kNone, kFlagNone,
       kTypeHostedApp | kTypePackagedApp);
 
   // Register extension permissions.
   info->RegisterPermission(
       kBookmark, "bookmarks", IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,
@@ skipping 16 matching lines @@
       kHistory, "history", IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY,
       ExtensionPermissionMessage::kBrowsingHistory,
       kFlagNone, kTypeDefault);
   info->RegisterPermission(
       kIdle, "idle", 0, ExtensionPermissionMessage::kNone,
       kFlagNone, kTypeDefault);
   info->RegisterPermission(
       kInput, "input", 0, ExtensionPermissionMessage::kNone,
       kFlagImpliesFullURLAccess, kTypeDefault);
   info->RegisterPermission(
-      kInputMethodPrivate, "inputMethodPrivate", 0,
-      ExtensionPermissionMessage::kNone, kFlagCannotBeOptional, kTypeDefault);
-  info->RegisterPermission(
       kManagement, "management", IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,
       ExtensionPermissionMessage::kManagement, kFlagNone, kTypeDefault);
   info->RegisterPermission(
       kPageCapture, "pageCapture",
       IDS_EXTENSION_PROMPT_WARNING_ALL_PAGES_CONTENT,
       ExtensionPermissionMessage::kAllPageContent, kFlagNone, kTypeDefault);
   info->RegisterPermission(
       kPrivacy, "privacy", IDS_EXTENSION_PROMPT_WARNING_PRIVACY,
       ExtensionPermissionMessage::kPrivacy, kFlagNone, kTypeDefault);
   info->RegisterPermission(
       kStorage, "storage", 0,
       ExtensionPermissionMessage::kNone, kFlagNone, kTypeDefault);
   info->RegisterPermission(
       kTab, "tabs", IDS_EXTENSION_PROMPT_WARNING_TABS,
       ExtensionPermissionMessage::kTabs, kFlagNone,
       kTypeDefault - kTypePlatformApp);
   info->RegisterPermission(
-      kTerminalPrivate, "terminalPrivate", 0,
-      ExtensionPermissionMessage::kNone, kFlagCannotBeOptional, kTypeDefault);
-  info->RegisterPermission(
       kTts, "tts", 0,
       ExtensionPermissionMessage::kNone, kFlagCannotBeOptional, kTypeDefault);
   info->RegisterPermission(
       kTtsEngine, "ttsEngine", IDS_EXTENSION_PROMPT_WARNING_TTS_ENGINE,
       ExtensionPermissionMessage::kTtsEngine,
       kFlagCannotBeOptional, kTypeDefault);
   info->RegisterPermission(
       kWebNavigation, "webNavigation",
       IDS_EXTENSION_PROMPT_WARNING_TABS, ExtensionPermissionMessage::kTabs,
       kFlagNone, kTypeDefault - kTypePlatformApp);
   info->RegisterPermission(
       kWebRequest, "webRequest", 0, ExtensionPermissionMessage::kNone,
       kFlagNone, kTypeDefault - kTypePlatformApp);
   info->RegisterPermission(
       kWebRequestBlocking, "webRequestBlocking", 0,
       ExtensionPermissionMessage::kNone, kFlagNone,
       kTypeDefault - kTypePlatformApp);
-  info->RegisterPermission(
-      kWebSocketProxyPrivate, "webSocketProxyPrivate", 0,
-      ExtensionPermissionMessage::kNone, kFlagCannotBeOptional,
-      kTypeDefault - kTypePlatformApp);
 
   // Register private permissions.
+  ExtensionAPIPermission* chromeAuthPrivate = info->RegisterPermission(
+      kChromeAuthPrivate, "chromeAuthPrivate", 0,
+      ExtensionPermissionMessage::kNone,
+      kFlagCannotBeOptional, kTypeAll - kTypePlatformApp);
+  for (size_t i = 0; i < arraysize(kChromeAuthPrivateWhitelist); ++i)
+    chromeAuthPrivate->AddToWhitelist(kChromeAuthPrivateWhitelist[i]);
+  ExtensionAPIPermission* chromePrivate = info->RegisterPermission(
+      kChromePrivate, "chromePrivate", 0, ExtensionPermissionMessage::kNone,
+      kFlagCannotBeOptional, kTypeAll - kTypePlatformApp);
+  for (size_t i = 0; i < arraysize(kChromePrivateWhitelist); ++i)
+    chromePrivate->AddToWhitelist(kChromePrivateWhitelist[i]);
   info->RegisterPermission(
       kChromeosInfoPrivate, "chromeosInfoPrivate", 0,
       ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeDefault);
+      kFlagComponentOnly_Deprecated | kFlagCannotBeOptional, kTypeDefault);
   info->RegisterPermission(
       kFileBrowserPrivate, "fileBrowserPrivate", 0,
       ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeDefault);
+      kFlagComponentOnly_Deprecated | kFlagCannotBeOptional, kTypeDefault);
+  ExtensionAPIPermission* inputMethodPrivate = info->RegisterPermission(
+      kInputMethodPrivate, "inputMethodPrivate", 0,
+      ExtensionPermissionMessage::kNone, kFlagCannotBeOptional, kTypeDefault);
+  for (size_t i = 0; i < arraysize(kChromeOSWhitelist); ++i)
+    inputMethodPrivate->AddToWhitelist(kChromeOSWhitelist[i]);
   info->RegisterPermission(
       kMediaPlayerPrivate, "mediaPlayerPrivate", 0,
       ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeDefault);
+      kFlagComponentOnly_Deprecated | kFlagCannotBeOptional, kTypeDefault);
   info->RegisterPermission(
       kMetricsPrivate, "metricsPrivate", 0,
       ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeDefault);
+      kFlagComponentOnly_Deprecated | kFlagCannotBeOptional, kTypeDefault);
   info->RegisterPermission(
       kSystemPrivate, "systemPrivate", 0,
       ExtensionPermissionMessage::kNone,
-      kFlagComponentOnly | kFlagCannotBeOptional, kTypeDefault);
+      kFlagComponentOnly_Deprecated | kFlagCannotBeOptional, kTypeDefault);
+  ExtensionAPIPermission* terminalPrivate = info->RegisterPermission(
+      kTerminalPrivate, "terminalPrivate", 0, ExtensionPermissionMessage::kNone,
+      kFlagCannotBeOptional, kTypeDefault);
+  for (size_t i = 0; i < arraysize(kTerminalPrivateWhitelist); ++i)

[Aaron Boodman, 2012/02/02 18:17:31]

Nit: instead of duplicating this loop everywhere, you can just get rid of the
constant array and call AddToWhitelist() for each entry. You're not saving
anything abstracting it to an array.

[jstritar, 2012/02/03 14:33:17]

Done.

+    terminalPrivate->AddToWhitelist(kTerminalPrivateWhitelist[i]);
+  ExtensionAPIPermission* webSocketProxyPrivate = info->RegisterPermission(

[Aaron Boodman, 2012/02/02 18:17:31]

Maybe also move the ones that have whitelists to the end of this section and put
line breaks between them for readability.

[jstritar, 2012/02/03 14:33:17]

Done.

+      kWebSocketProxyPrivate, "webSocketProxyPrivate", 0,
+      ExtensionPermissionMessage::kNone,
+      kFlagCannotBeOptional, kTypeDefault - kTypePlatformApp);
+  for (size_t i = 0; i < arraysize(kChromeOSWhitelist); ++i)
+    webSocketProxyPrivate->AddToWhitelist(kChromeOSWhitelist[i]);
+  ExtensionAPIPermission* webstorePrivate = info->RegisterPermission(
+      kWebstorePrivate, "webstorePrivate", 0,
+      ExtensionPermissionMessage::kNone,
+      kFlagCannotBeOptional, kTypeAll - kTypePlatformApp);
+  for (size_t i = 0; i < arraysize(kWebstorePrivateWhitelist); ++i)
+    webstorePrivate->AddToWhitelist(kWebstorePrivateWhitelist[i]);
 
   // Full url access permissions.
   info->RegisterPermission(
       kProxy, "proxy", 0, ExtensionPermissionMessage::kNone,
       kFlagImpliesFullURLAccess | kFlagCannotBeOptional, kTypeDefault);
 
   info->RegisterPermission(
       kDebugger, "debugger", IDS_EXTENSION_PROMPT_WARNING_DEBUGGER,
       ExtensionPermissionMessage::kDebugger,
       kFlagImpliesFullURLAccess | kFlagCannotBeOptional, kTypeDefault);
@@ skipping 10 matching lines @@
   // Platform-app permissions.
   info->RegisterPermission(
       kSocket, "socket", 0, ExtensionPermissionMessage::kNone,
       kFlagCannotBeOptional, kTypePlatformApp);
 
   // Register aliases.
   info->RegisterAlias("unlimitedStorage", kOldUnlimitedStoragePermission);
   info->RegisterAlias("tabs", kWindowsPermission);
 }
 
+bool ExtensionAPIPermission::HasWhitelist() const {
+  return !whitelist_.empty();
+}
+
+bool ExtensionAPIPermission::IsWhitelisted(
+    const std::string& extension_id) const {
+  return whitelist_.find(extension_id) != whitelist_.end();
+}
+
+void ExtensionAPIPermission::AddToWhitelist(const std::string& extension_id) {
+  whitelist_.insert(extension_id);
+}
+
 //
 // ExtensionPermissionsInfo
 //
 
 // static
 ExtensionPermissionsInfo* ExtensionPermissionsInfo::GetInstance() {
   return Singleton<ExtensionPermissionsInfo>::get();
 }
 
 ExtensionAPIPermission* ExtensionPermissionsInfo::GetByID(
@@ skipping 37 matching lines @@
   ExtensionAPIPermission::RegisterAllPermissions(this);
 }
 
 void ExtensionPermissionsInfo::RegisterAlias(
     const char* name, const char* alias) {
   DCHECK(name_map_.find(name) != name_map_.end());
   DCHECK(name_map_.find(alias) == name_map_.end());
   name_map_[alias] = name_map_[name];
 }
 
-void ExtensionPermissionsInfo::RegisterPermission(
+ExtensionAPIPermission* ExtensionPermissionsInfo::RegisterPermission(
     ExtensionAPIPermission::ID id,
     const char* name,
     int l10n_message_id,
     ExtensionPermissionMessage::ID message_id,
     int flags,
     int type_restrictions) {
   DCHECK(id_map_.find(id) == id_map_.end());
   DCHECK(name_map_.find(name) == name_map_.end());
 
   ExtensionAPIPermission* permission = new ExtensionAPIPermission(
       id, name, l10n_message_id, message_id, flags, type_restrictions);
 
   id_map_[id] = permission;
   name_map_[name] = permission;
 
   permission_count_++;
+
+  return permission;
 }
 
 //
 // ExtensionPermissionSet
 //
 
 ExtensionPermissionSet::ExtensionPermissionSet() {
 }
 
 ExtensionPermissionSet::ExtensionPermissionSet(
@@ skipping 442 matching lines @@
   std::set<std::string> new_hosts_set(GetDistinctHosts(new_list, false, false));
   std::set<std::string> old_hosts_set(GetDistinctHosts(old_list, false, false));
   std::set<std::string> new_hosts_only;
 
   std::set_difference(new_hosts_set.begin(), new_hosts_set.end(),
                       old_hosts_set.begin(), old_hosts_set.end(),
                       std::inserter(new_hosts_only, new_hosts_only.begin()));
 
   return !new_hosts_only.empty();
 }