Add a centralized mechanism for whitelisting access to extension permissions.

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 557 matching lines @@
 
   // Forbid options page with non-(http|https) scheme in hosted app.
   LoadAndExpectError("hosted_app_file_options.json",
                      errors::kInvalidOptionsPageInHostedApp);
 
   // Forbid absolute URL for options page in packaged apps.
   LoadAndExpectError("packaged_app_absolute_options.json",
                      errors::kInvalidOptionsPageExpectUrlInPackage);
 }
 
-TEST_F(ExtensionManifestTest, HostedAppPermissions) {
-  std::string error;
-  scoped_ptr<DictionaryValue> manifest(
-      LoadManifestFile("hosted_app_absolute_options.json", &error));
-  ASSERT_TRUE(manifest.get());
-  ListValue* permissions = NULL;
-  ASSERT_TRUE(manifest->GetList("permissions", &permissions));
-
-  int platform_app = ExtensionAPIPermission::kTypePlatformApp;
-  ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
-  ExtensionAPIPermissionSet api_perms = info->GetAll();
-  for (ExtensionAPIPermissionSet::iterator i = api_perms.begin();
-       i != api_perms.end(); ++i) {
-    if (*i == ExtensionAPIPermission::kExperimental)
-      continue;
-
-    ExtensionAPIPermission* permission = info->GetByID(*i);
-    const char* name = permission->name();
-    StringValue* p = new StringValue(name);
-    permissions->Clear();
-    permissions->Append(p);
-
-    // Some permissions are only available to component hosted apps.
-    if (permission->is_component_only()) {
-      LoadAndExpectError(Manifest(manifest.get(), name),
-                         errors::kPermissionNotAllowed,
-                         Extension::INTERNAL);
-      scoped_refptr<Extension> extension(
-          LoadAndExpectSuccess(Manifest(manifest.get(), name),
-                               Extension::COMPONENT));
-      EXPECT_TRUE(extension->GetActivePermissions()->HasAPIPermission(
-          permission->id()));
-
-    } else if (permission->type_restrictions() == platform_app) {
-      LoadAndExpectError(Manifest(manifest.get(), name),
-                         errors::kPermissionNotAllowed,
-                         Extension::INTERNAL,
-                         Extension::STRICT_ERROR_CHECKS);
-    } else if (!permission->supports_hosted_apps()) {
-      // Most normal extension permissions also aren't available to hosted apps.
-      // For these, the error is only reported in strict mode for legacy
-      // reasons: crbug.com/101993.
-      LoadAndExpectError(Manifest(manifest.get(), name),
-                         errors::kPermissionNotAllowed,
-                         Extension::INTERNAL,
-                         Extension::STRICT_ERROR_CHECKS);
-      scoped_refptr<Extension> extension(
-          LoadAndExpectSuccess(Manifest(manifest.get(), name),
-                               Extension::INTERNAL));
-      EXPECT_FALSE(extension->GetActivePermissions()->HasAPIPermission(
-          permission->id()));
-
-      // These permissions are also allowed for component hosted apps.
-      extension = LoadAndExpectSuccess(Manifest(manifest.get(), name),
-                                       Extension::COMPONENT);
-      EXPECT_TRUE(extension->GetActivePermissions()->HasAPIPermission(
-          permission->id()));
-
-    } else {
-      scoped_refptr<Extension> extension(
-          LoadAndExpectSuccess(Manifest(manifest.get(), name)));
-      EXPECT_TRUE(extension->GetActivePermissions()->HasAPIPermission(
-          permission->id()));
-    }
-  }
-}
-
-TEST_F(ExtensionManifestTest, ComponentOnlyPermission) {
-  std::string error;
-  scoped_ptr<DictionaryValue> manifest(
-      LoadManifestFile("init_valid_minimal.json", &error));
-  ASSERT_TRUE(manifest.get());
-  ListValue* permissions = new ListValue();
-  manifest->Set("permissions", permissions);
-
-  ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
-  ExtensionAPIPermissionSet api_perms = info->GetAll();
-  for (ExtensionAPIPermissionSet::iterator i = api_perms.begin();
-       i != api_perms.end(); ++i) {
-    if (*i == ExtensionAPIPermission::kExperimental)
-      continue;
-
-    ExtensionAPIPermission* permission = info->GetByID(*i);
-    const char* name = permission->name();
-    StringValue* p = new StringValue(name);
-    permissions->Clear();
-    permissions->Append(p);
-
-    if (!permission->is_component_only())
-      continue;
-
-    // Component-only extensions should only be enabled for component
-    // extensions.
-    LoadAndExpectError(Manifest(manifest.get(), name),
-                       errors::kPermissionNotAllowed);
-    LoadAndExpectSuccess(Manifest(manifest.get(), name),
-                         Extension::COMPONENT);
-  }
-}
-
 TEST_F(ExtensionManifestTest, AllowUnrecognizedPermissions) {
   std::string error;
   scoped_ptr<DictionaryValue> manifest(
       LoadManifestFile("valid_app.json", &error));
   ListValue* permissions = NULL;
   ASSERT_TRUE(manifest->GetList("permissions", &permissions));
   permissions->Append(new StringValue("not-a-valid-permission"));
   LoadAndExpectSuccess(Manifest(manifest.get(), ""));
 }
 
@@ skipping 370 matching lines @@
   EXPECT_EQ("", extension->page_action()->id());
   EXPECT_EQ(0u, extension->page_action()->icon_paths()->size());
   EXPECT_EQ("", extension->page_action()->GetTitle(
       ExtensionAction::kDefaultTabId));
   EXPECT_FALSE(extension->page_action()->HasPopup(
       ExtensionAction::kDefaultTabId));
 
   LoadAndExpectError("page_action_manifest_version_2b.json",
                      errors::kInvalidPageActionPopup);
 }