Add a centralized mechanism for whitelisting access to extension permissions.

chrome/browser/extensions/extension_webstore_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_webstore_private_api.h"
 
 #include <string>
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 35 matching lines @@
 const char kTokenKey[] = "token";
 
 const char kCannotSpecifyIconDataAndUrlError[] =
     "You cannot specify both icon data and an icon url";
 const char kInvalidIconUrlError[] = "Invalid icon url";
 const char kInvalidIdError[] = "Invalid id";
 const char kInvalidManifestError[] = "Invalid manifest";
 const char kNoPreviousBeginInstallWithManifestError[] =
     "* does not match a previous call to beginInstallWithManifest3";
 const char kUserCancelledError[] = "User cancelled install";
-const char kPermissionDeniedError[] =
-    "You do not have permission to use this method.";
 
 ProfileSyncService* test_sync_service = NULL;
 
 // Returns either the test sync service, or the real one from |profile|.
 ProfileSyncService* GetSyncService(Profile* profile) {
   // TODO(webstore): It seems |test_sync_service| is not used anywhere. It
   // should be removed.
   if (test_sync_service)
     return test_sync_service;
   else
     return ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile);
 }
 
-bool IsWebStoreURL(Profile* profile, const GURL& url) {
-  ExtensionService* service = profile->GetExtensionService();
-  const Extension* store = service->GetWebStoreApp();
-  if (!store) {
-    NOTREACHED();
-    return false;
-  }
-  return (service->extensions()->GetHostedAppByURL(ExtensionURLInfo(url)) ==
-          store);
-}
-
 // Whitelists extension IDs for use by webstorePrivate.silentlyInstall.
 bool trust_test_ids = false;
 
 bool IsTrustedForSilentInstall(const std::string& id) {
   // Trust the extensions in api_test/webstore_private/bundle when the flag
   // is set.
   if (trust_test_ids &&
       (id == "begfmnajjkbjdgmffnjaojchoncnmngg" ||
        id == "bmfoocgfinpmkmlbjhcbofejhkhlbchk" ||
        id == "mpneghmdnmaolkljkipbhaienajcflfe"))
@@ skipping 52 matching lines @@
 void WebstorePrivateApi::SetTrustTestIDsForTesting(bool allow) {
   trust_test_ids = allow;
 }
 
 BeginInstallWithManifestFunction::BeginInstallWithManifestFunction()
   : use_app_installed_bubble_(false) {}
 
 BeginInstallWithManifestFunction::~BeginInstallWithManifestFunction() {}
 
 bool BeginInstallWithManifestFunction::RunImpl() {
-  if (!IsWebStoreURL(profile_, source_url())) {
-    SetResult(PERMISSION_DENIED);
-    return false;
-  }
-
   DictionaryValue* details = NULL;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details));
   CHECK(details);
 
   EXTENSION_FUNCTION_VALIDATE(details->GetString(kIdKey, &id_));
   if (!Extension::IdIsValid(id_)) {
     SetResult(INVALID_ID);
     error_ = kInvalidIdError;
     return false;
   }
@@ skipping 176 matching lines @@
       "Extensions.Permissions_InstallCancel" :
       "Extensions.Permissions_InstallAbort";
   ExtensionService::RecordPermissionMessagesHistogram(
       dummy_extension_, histogram_name.c_str());
 
   // Matches the AddRef in RunImpl().
   Release();
 }
 
 bool CompleteInstallFunction::RunImpl() {
-  if (!IsWebStoreURL(profile_, source_url()))
-    return false;
-
   std::string id;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &id));
   if (!Extension::IdIsValid(id)) {
     error_ = kInvalidIdError;
     return false;
   }
 
   if (!CrxInstaller::IsIdWhitelisted(id) &&
       !CrxInstaller::GetWhitelistEntry(id)) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
@@ skipping 10 matching lines @@
       id, WebstoreInstaller::FLAG_NONE);
   installer->Start();
 
   return true;
 }
 
 SilentlyInstallFunction::SilentlyInstallFunction() {}
 SilentlyInstallFunction::~SilentlyInstallFunction() {}
 
 bool SilentlyInstallFunction::RunImpl() {
-  if (!IsWebStoreURL(profile_, source_url())) {
-    error_ = kPermissionDeniedError;
-    return false;
-  }
-
   DictionaryValue* details = NULL;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details));
   CHECK(details);
 
   EXTENSION_FUNCTION_VALIDATE(details->GetString(kIdKey, &id_));
   if (!IsTrustedForSilentInstall(id_)) {
     error_ = kInvalidIdError;
     return false;
   }
 
@@ skipping 55 matching lines @@
     const std::string& id, const std::string& error) {
   CHECK_EQ(id_, id);
 
   error_ = error;
   SendResponse(false);
 
   Release();  // Matches the AddRef() in RunImpl().
 }
 
 bool GetBrowserLoginFunction::RunImpl() {
-  if (!IsWebStoreURL(profile_, source_url()))
-    return false;
   result_.reset(CreateLoginResult(profile_->GetOriginalProfile()));
   return true;
 }
 
 bool GetStoreLoginFunction::RunImpl() {
-  if (!IsWebStoreURL(profile_, source_url()))
-    return false;
   ExtensionService* service = profile_->GetExtensionService();
   ExtensionPrefs* prefs = service->extension_prefs();
   std::string login;
   if (prefs->GetWebStoreLogin(&login)) {
     result_.reset(Value::CreateStringValue(login));
   } else {
     result_.reset(Value::CreateStringValue(std::string()));
   }
   return true;
 }
 
 bool SetStoreLoginFunction::RunImpl() {
-  if (!IsWebStoreURL(profile_, source_url()))
-    return false;
   std::string login;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &login));
   ExtensionService* service = profile_->GetExtensionService();
   ExtensionPrefs* prefs = service->extension_prefs();
   prefs->SetWebStoreLogin(login);
   return true;
 }
 
 GetWebGLStatusFunction::GetWebGLStatusFunction() {}
 GetWebGLStatusFunction::~GetWebGLStatusFunction() {}
@@ skipping 49 matching lines @@
     SendResponse(true);
   } else {
     // Matched with a Release in OnGpuInfoUpdate.
     AddRef();
 
     manager->AddObserver(this);
     manager->RequestCompleteGpuInfoIfNeeded();
   }
   return true;
 }