Store the UploadData identifier in NavigationEntryImpl.

Store the UploadData identifier in NavigationEntryImpl.

This will ultimately be used to help save content that was retrieved from a POST.

A few points:
  - The identifier can be recovered from the TabRestoreService
  - The identifier is not persisted to disk for either the session or the tab service.
  
The identifier is redundant with data in the "opaque" state_ string, but we decided to go this route. See http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/9f521b7c18850b3b/ for a discussion of alternative approaches.

BUG=55551
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120369

[cbentzel, 2012-02-01 21:54:23]

I was looking at possible tests for this change, but it doesn't seem like there
are any relevant ones. 

A separate CL which exercises this data will have browser_tests which fail if
the post_id is not present.

http://codereview.chromium.org/9314037/

[cbentzel, 2012-02-01 21:58:40]

sky: chrome/browser/sessions and other sanity checks
darin: content
marja: Please review, since there is some overlap with your POST body
persistence CL.

[cbentzel, 2012-02-01 22:02:13]

http://codereview.chromium.org/9317009/diff/9001/chrome/browser/sessions/sess...
File chrome/browser/sessions/session_types.cc (right):

http://codereview.chromium.org/9317009/diff/9001/chrome/browser/sessions/sess...
chrome/browser/sessions/session_types.cc:95: post_id_ = entry.GetPostID();
post_id_ is explicitly not being persisted or restored in this CL, hence the
lack of change to BaseSessionService.

http://codereview.chromium.org/9317009/diff/9001/content/common/view_messages.h
File content/common/view_messages.h (right):

http://codereview.chromium.org/9317009/diff/9001/content/common/view_messages...
content/common/view_messages.h:446: // The POST body identifier. -1 if it
doesn't exist.
I considered removing the |is_post| field in favor of just the |post_id| field,
but was concerned that there may be cases where the method is "POST" but there
is no WebHistoryItem or httpBody attached to that item. See render_view_impl.cc
for that.

[cbentzel, 2012-02-01 22:02:59]

+avi for content/public

[darin (slow to review), 2012-02-02 06:10:20]

LGTM

[marja, 2012-02-03 13:15:31]

LGTM, looks like this doesn't overlap with my POST data storing & restoring work
that much.

[cbentzel, 2012-02-03 15:20:00]

On 2012/02/03 13:15:31, marja wrote:
> LGTM, looks like this doesn't overlap with my POST data storing & restoring
work
> that much.

The only place this may overlap is on Session Restore - if we're able to retain
the state, it might be nice to also persist and restore the post_id on the
NavigationEntry.

[cbentzel, 2012-02-03 15:38:13]

+jam

John - Avi thought you might want to take a look at this CL, particularly the
content/public/navigation_entry change.

[Avi (use Gerrit), 2012-02-03 15:39:11]

lgtm

[sky, 2012-02-03 18:18:39]

LGTM

[commit-bot: I haz the power, 2012-02-03 18:23:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9317009/9001

[commit-bot: I haz the power, 2012-02-03 19:51:07]

Change committed as 120369