Don't strip punctuation inside quotes in history search queries.

chrome/browser/history/query_parser_unittest.cc

Index: chrome/browser/history/query_parser_unittest.cc
diff --git a/chrome/browser/history/query_parser_unittest.cc b/chrome/browser/history/query_parser_unittest.cc
index 50ea3263bc842295cd4066e2677a508de5251b10..11ccb7d0b747188197184b74e71211970a7f72b9 100644
--- a/chrome/browser/history/query_parser_unittest.cc
+++ b/chrome/browser/history/query_parser_unittest.cc
@@ -57,6 +57,8 @@ TEST_F(QueryParserTest, Quoted) {
   EXPECT_EQ("miss* beg*", QueryToString("miss beg\""));
   // Weird formatting
   EXPECT_EQ("\"Many\" \"quotes\"", QueryToString("\"Many   \"\"quotes"));
+  EXPECT_EQ("\"ab\" cd \"ef\"", QueryToString("\"ab\" cd \"ef\""));
+  EXPECT_EQ("tra* \"la\" la", QueryToString("tra \"la\" la"));
 }
 
 // Apostrophes within words should be preserved, but otherwise stripped.
@@ -69,6 +71,19 @@ TEST_F(QueryParserTest, Apostrophes) {
 // Special characters.
 TEST_F(QueryParserTest, SpecialChars) {
   EXPECT_EQ("foo* the* bar*", QueryToString("!#:/*foo#$*;'* the!#:/*bar"));
+
+  // URL-like queries should be left intact.
+  EXPECT_EQ("chromium.org/fun*", QueryToString("chromium.org/fun"));
+  EXPECT_EQ("a.b.c/~x-y-zed*", QueryToString("a.b.c/~x-y-zed"));
+
+  // Special chars inside quotes should be preserved.
+  EXPECT_EQ("\"$FOO\" bar*", QueryToString("\"$FOO\" .bar*"));
+  EXPECT_EQ("\"aa #&$ bb\"", QueryToString("\"aa #&$ bb\""));
+
+  // Leading punctuation should always be stripped.
+  EXPECT_EQ("test*", QueryToString(".test"));
+  EXPECT_EQ("test.*", QueryToString("~test."));
+  EXPECT_EQ("test*", QueryToString("--test"));

[mrossetti, 2012/02/09 00:27:03]

Excellent unit test additions!

May I suggest adding a test where there are escaped characters:
"query&path=foo%20bar" or somesuch, for example.

[Patrick Dubroy, 2012/02/09 14:47:00]

Good idea, done.

 }
 
 TEST_F(QueryParserTest, NumWords) {