Chromium Code Reviews| Index: SConstruct |
| diff --git a/SConstruct b/SConstruct |
| index 8199beb07d7f134541078427f5d73c1a6a56bf53..4234499e0eba370fed8450c2a28674fbabdc9205 100755 |
| --- a/SConstruct |
| +++ b/SConstruct |
| @@ -1605,14 +1605,15 @@ def PPAPIBrowserTester(env, |
| continue |
| stream_file = env.subst(params['file']) |
| command.extend(['--nacl_exe_' + stream, stream_file]) |
| - golden_file = env.subst(params['golden']) |
| - filter_regex = params.get('filter_regex', None) |
| - filter_inverse = params.get('filter_inverse', False) |
| - filter_group_only = params.get('filter_group_only', False) |
| - post_actions.append( |
| - GoldenFileCheckAction( |
| - env, stream_file, golden_file, |
| - filter_regex, filter_inverse, filter_group_only)) |
| + if 'golden' in params: |
| + golden_file = env.subst(params['golden']) |
| + filter_regex = params.get('filter_regex', None) |
| + filter_inverse = params.get('filter_inverse', False) |
| + filter_group_only = params.get('filter_group_only', False) |
| + post_actions.append( |
| + GoldenFileCheckAction( |
| + env, stream_file, golden_file, |
| + filter_regex, filter_inverse, filter_group_only)) |
| if ShouldUseVerboseOptions(extra): |
| env.MakeVerboseExtraOptions(target, log_verbosity, extra) |
| @@ -3282,6 +3283,7 @@ nonvariant_tests = [ |
| 'tests/ppapi_tests/nacl.scons', |
| 'tests/pyauto_nacl/nacl.scons', |
| 'tests/unittests/shared/imc/nacl.scons', |
| + 'tests/untrusted_crash_dump/nacl.scons', |
|
Mark Seaborn
2012/02/13 19:04:08
I noticed your change "taking out of irt tests".
bradn
2012/02/13 23:42:03
Had some trouble or other with the build, left in
|
| 'tests/unittests/shared/srpc/nacl.scons', |
| 'tests/windows_crash_in_syscall/nacl.scons', |
| #### ALPHABETICALLY SORTED #### |