Adding untrusted crash dump / stack trace tests.

src/trusted/service_runtime/build.scons

 # -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import platform
 import os
 
 Import('env')
 
@@ skipping 301 matching lines @@
                 'nacl_fault_inject',
                 'platform',
                 'platform_qual_lib',
                 VALIDATOR_LIB,
                 ] + DEBUG_LIBS
 if ((not env.Bit('coverage_enabled') or not env.Bit('windows')) and
     not env.CrossToolsBuild()):
   sel_main_objs = [env.ComponentObject('sel_main.c')] + r_debug_objs
   SEL_LDR_NODE = env.ComponentProgram('sel_ldr', sel_main_objs,
                                       EXTRA_LIBS=sel_ldr_libs)
+  # TODO(bradnelson): drop once exceptions are available by default.
+  env_exc = env.Clone()
+  env_exc.Append(CPPDEFINES=['NACL_EXCEPTION_HANDLING_REQUESTED'])
+  exc_sel_main_objs = [
+      env_exc.ComponentObject('sel_main_exc', 'sel_main.c')] + r_debug_objs

[Mark Seaborn, 2012/02/06 17:35:04]

This sets a bad precedent.  I don't want to start building different variants of
sel_ldr that differ only in whether an option is enabled or disabled.  If we did
this for more options there would be an exponential explosion.  Can you use an
environment variable for enabling exception handling instead?

[bradn, 2012/02/06 19:26:59]

Done.
Odd, I didn't know the environment get propagated thru like that.
Is that wise?
I had the impression is was scrubbed.

+  exc_SEL_LDR_NODE = env_exc.ComponentProgram('sel_ldr_exc', exc_sel_main_objs,
+                                              EXTRA_LIBS=sel_ldr_libs)
   if env.Bit('mac'):
     # This target exists only to check that the service_runtime code
     # can successfully be linked into a Mac OS X dynamic library.  Our
     # assembly code needs to be PIC-friendly and linkable in this
     # context, because it is linked into a dynamic library inside
     # Chromium, and OS X is strict about TEXTRELs.  Without this, the
     # standalone build won't catch some mistakes that can break the
     # Chromium build.  Linking a dylib here works because -fPIC is the
     # default for all C code on OS X.
     dylib_env = env.Clone()
@@ skipping 620 matching lines @@
     expected_exit_status = 'sigabrt'
   node = env.CommandTest(
       'sel_ldr_thread_death_test.out',
       command=[sel_ldr_thread_death_test_exe],
       exit_status=expected_exit_status)
 
   # TODO(tuduce): Make it work on windows.
   env.AddNodeToTestSuite(node, ['medium_tests'],
                          'run_sel_ldr_thread_death_test',
                          is_broken=env.Bit('windows'))