tests/untrusted_crash_dump/untrusted_crash_dump_test_glibc.golden - Issue 9316125: Adding untrusted crash dump / stack trace tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/untrusted_crash_dump/untrusted_crash_dump_test_glibc.golden

Issue 9316125: Adding untrusted crash dump / stack trace tests. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fixing review comments 2 Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 layer5 at untrusted_crash_dump_test.c:21

	2 layer4 at untrusted_crash_dump_test.c:26

	3 CallMe at untrusted_crash_dump_lib.c:9

	4 layer3 at untrusted_crash_dump_test.c:30

	5 layer2 at untrusted_crash_dump_test.c:34

	6 layer1 at untrusted_crash_dump_test.c:38

	7 main at untrusted_crash_dump_test.c:45

	8 __libc_start_main at libc-start.c:227
	Mark Seaborn 2012/02/09 22:24:55 I don't like having glibc line numbers in golden f I don't like having glibc line numbers in golden files. It will just create problems for anyone updating DEPS or running the tests on different libc versions. My suggestion: Have a Python test script that does this: * imports decode_dump.py * Calls a function in decode_dump to get an unformatted backtrace as a Python list. * Assert that the list starts with the function names "layer5", "layer4" etc. with the filename "untrusted_crash_dump_test.c". * Don't embed line numbers in the test. But you can check a couple of line numbers by reading the line from the file (using Python's linecache) and asserting that the line contains a special comment. * Also check that you can format the backtrace without getting a Python exception (but don't look at the formatted backtrace itself).
	9 _start at start.c:39

OLD	NEW